Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Fix for issue #2812 #2824

Closed
wants to merge 3 commits into from
Closed

Fix for issue #2812 #2824

wants to merge 3 commits into from

Conversation

loicoudot
Copy link

fix(dateparser): Optional loeading '0' in 'M' and 'd' dateparser
fix(dateparser): Optional leading '0' for 'M' and 'd' dateparser
Appply patch for  #2659
@pkozlowski-opensource
Copy link
Member

@loicoudot your proposed change for leading 0 sounds reasonable, I guess this is what commits d660726 and 95abaaf are taking care of. But I'm puzzled by 7f272f4. Why is it part of this PR? What is it trying to fix?

To move forward on this one we would need one PR for one functional change with all the commits squashed.

@loicoudot
Copy link
Author

You're completely right, 7f272f4 is for an another patch, I can't find the way to remove this commit from the PR.
Do you want an another PR with only the first two ones ?

@pkozlowski-opensource
Copy link
Member

@loicoudot yeh, this would be great. On top of this if you could squash 2 commits into one and follow our commit message convention - this would be totally awesome.

@loicoudot
Copy link
Author

I've created #2855 hope this time it's good.
Closing this one.

@loicoudot loicoudot closed this Oct 19, 2014
@pkozlowski-opensource
Copy link
Member

@loicoudot #2855 indeed looks good. If there is any patch you would like to land as part of 7f272f4 please open a separate PR for it. Thnx!

@loicoudot
Copy link
Author

The commit 7f272f4 was the patch proposed by
#2659 that we need because we encountered that bug.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants