This repository was archived by the owner on May 29, 2019. It is now read-only.
feat(pagination): Show ellipsis when rotating #3035
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is for the feature request: #2924 |
|
This appears to be a breaking change - this should be an opt-in feature. |
This was referenced Apr 19, 2015
|
Closing as this PR wasn't touched for 6 months and the [comment[(https://github.com//pull/3035#issuecomment-85867895) wasn't addressed. It seems like we've got another PR for the same: https://github.com//pull/3565 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have more pages than can be shown and we're rotating, shows ellipsis' like:
Previous, ..., 3, 4, 5, 6, 7, ..., Next
This also adds a handy function in the tests to convert the pager to a string, so that we can intuitively check the state of the pager all at once, instead of having to check each element's text individually.