This repository was archived by the owner on May 29, 2019. It is now read-only.
fix(modal): Fix background move a little when opening a modal #3144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var bodyPad = 0; | ||
| var scrollBarWidth = 0; | ||
| var body = $document.find('body').eq(0); | ||
| var fixedElements = angular.element($document[0].querySelector('.navbar-fixed-top, .navbar-fixed-bottom, .affix')); |
There was a problem hiding this comment.
Use
var fixedElements = angular.element(body.querySelector('.navbar-fixed-top, .navbar-fixed-bottom, .affix'));
|
Can you create a Plunker illustrating this in action? |
| @@ -266,6 +290,8 @@ angular.module('ui.bootstrap.modal', ['ui.bootstrap.transition']) | |||
| openedWindows.top().value.modalDomEl = modalDomEl; | |||
| body.append(modalDomEl); | |||
| body.addClass(OPENED_MODAL_CLASS); | |||
|
|
|||
| if (scrollBarWidth) { setScrollBar(); } | |||
There was a problem hiding this comment.
You should check if backdrop index is zero here. If you open modal, while another modal is open, it will shift body and fixed elements for another scrollbar width.
|
whats the status on this pr? |
This is a fix for issue #2631.This calculates the scrollbar width and add it to body and fixed navbar.
sifo
added a commit
to sifo/bootstrap-bower
that referenced
this pull request
Sep 20, 2015
sifo
added a commit
to sifo/bootstrap-bower
that referenced
this pull request
Sep 20, 2015
sifo
added a commit
to sifo/bootstrap-bower
that referenced
this pull request
Sep 20, 2015
sifo
added a commit
to sifo/bootstrap-bower
that referenced
this pull request
Sep 20, 2015
sifo
added a commit
to sifo/bootstrap-bower
that referenced
this pull request
Sep 20, 2015
sifo
added a commit
to sifo/bootstrap-bower
that referenced
this pull request
Sep 20, 2015
|
I am not able to reproduce it so I am not sure if this is stale or not. Please open an issue with a plunker if you think this is still an issue. Thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for issue #2631.This calculates the scrollbar width and add it to body and fixed navbar.