This repository was archived by the owner on May 29, 2019. It is now read-only.
docs(readme): add clarity on angular requirement #4278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe it's worth changing the comments to highly recommend using 1.3.18? I'm an advocate of letting people play with fire if they like, especially since that is sort of what we have seen to have enough of a presence in the community. |
|
I'm cool with that. @Foxandxss, I'll leave this as you're currently reworking the docs? |
* add a note indicating that due to critical animation fixes, UI Bootstrap 0.13.3 and higher requires Angular 1.3.18 or higher. addresses angular-ui#4277 docs(readme): add clarity on angular requirement * add note strongly recommending the use of Angular 1.3.18 or higher for UI Bootstrap 0.13.3 and higher due to animation fixes. addresses angular-ui#4277
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.13.3 and higher requires Angular 1.3.18 or higher.
addresses #4277