This repository was archived by the owner on May 29, 2019. It is now read-only.
chore: ensure tests are gc'd #5017
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleycho
force-pushed
the
chore/tests-gc
branch
from
93f0459 to
50bbb99
Compare
wesleycho
force-pushed
the
chore/tests-gc
branch
from
50bbb99 to
83c69c3
Compare
- Ensure event listeners globally on service instantiation are garbage collected properly
wesleycho
force-pushed
the
chore/tests-gc
branch
from
83c69c3 to
42e0102
Compare
|
Sounds good to me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
collected properly
This fixes #4996.