Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

fix(tabs): adding bootstrap 4 specific class #5488

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/tabs/test/tabs.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ describe('tabs', function() {
it('should pass class and other attributes on to tab template', function() {
expect(elm).toHaveClass('hello');
expect(elm.attr('data-pizza')).toBe('pepperoni');
//Ensure that we have bootstrap 4 link class so things are future proofed.
var link = $(elm.find('a')[0]);
expect(link).toHaveClass('nav-link');
});

it('should create clickable titles', function() {
Expand Down
4 changes: 2 additions & 2 deletions template/tabs/tab.html
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<li ng-class="{active: active, disabled: disabled}" class="uib-tab">
<a href ng-click="select()" uib-tab-heading-transclude>{{heading}}</a>
<li ng-class="{active: active, disabled: disabled}" class="uib-tab nav-item">
<a href ng-click="select()" class="nav-link" uib-tab-heading-transclude>{{heading}}</a>
</li>