Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

fix(position): getRawNode to handle select/ul elements #5491

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/position/position.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ angular.module('ui.bootstrap.position', [])
* @returns {element} A HTML element.
*/
getRawNode: function(elem) {
return elem[0] || elem;
return elem.nodeName ? elem : elem[0] || elem;
},

/**
Expand Down
14 changes: 14 additions & 0 deletions src/position/test/position.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,20 @@ describe('$uibPosition service', function () {
});
});

describe('rawnode', function() {
it('returns the raw DOM element from an angular element', function() {
var angularEl = angular.element('<div></div>');
var el = $uibPosition.getRawNode(angularEl);
expect(el.nodeName).toBe('DIV');
});

it('returns the raw DOM element from a select element', function() {
var angularEl = angular.element('<select><option value="value">value</option></select>');
var el = $uibPosition.getRawNode(angularEl);
expect(el.nodeName).toBe('SELECT');
});
});

describe('offset', function() {
it('returns getBoundingClientRect by default', function() {
var el = angular.element('<div>Foo</div>');
Expand Down