Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

docs(changelog): add missing breaking change #5554

Closed
wants to merge 1 commit into from
Closed

docs(changelog): add missing breaking change #5554

wants to merge 1 commit into from

Conversation

mattlewis92
Copy link
Contributor

As a sidenote, it might be worth employing something like semantic-release for incrementing the version number of the project to take the human decision out of the equation. As you now support npm and the default is to install with ^1.2.1 which assumes no breaking changes in minor releases this will break a lot of projects when running npm update if they don't lock dependencies. Just my $0.02, keep up the awesome work! 😄

@Foxandxss
Copy link
Contributor

I am not reaaaally fond of releasing after each push, but I agree that making this kind of BC on minor releases is wrong. We apologize for this.

@mattlewis92
Copy link
Contributor Author

You don't have to release on every push, you can make a new branch called release or w/e and only release when you merge into the branch so you still have full control over when you release a new version

@icfantv
Copy link
Contributor

icfantv commented Feb 29, 2016

closing as duplicate of #5555. I didn't see this before. thanks for the effort.

the onus is on us as developers to ensure we add BREAKING CHANGE to the commit message on a PR for an issue that has a breaking change. this is the only way the changelog generator will pick up the breaking change and add to the appropriate section.

@icfantv icfantv closed this Feb 29, 2016
@mattlewis92 mattlewis92 deleted the mattlewis92-tabs-changelog branch February 29, 2016 17:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants