This repository was archived by the owner on May 29, 2019. It is now read-only.
Typeahead: Fixed waitTime functionality #607
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@khalilravanna Cool! We've got another PR for the same, see: #594 Also, would be awesome to have a test exposing the issue. It seems like the current test we've got is completely useless as it passes regardless of the fix presence.... |
|
@pkozlowski-opensource I'm partial to my own solution just because it changes less code and it works for me locally. I'm going to work on creating a test now that can make sure those timeouts are being killed. |
|
@khalilravanna yeh, I like the fact that it touches less code and is shorter. A test would totally rock! |
|
Added a couple of tests to make sure that timeouts are squashed when within the waitTime, and are free to execute if waitTime has passed. |
|
Landed as 90a8aa7. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for bug #573.
This pull request fixes the bug where
$timeoutcalls were not cancelled even if they occurred in the time period defined bywaitTime.The reason for the bug was that
timeoutIdwas declared inside the scope of the function being pushed to$parsers, and therefore could not be referenced outside of the anonymous function. By declaring thetimeoutId, now renamedtimeoutPromise(because the return of$timeoutis not an id but actually a promise) above this function, the offending old$timeoutcalls can be killed.