Skip to content

fix(core): use allowFloatWidth property to allow float calculations for widths #7148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2021

Conversation

koganei
Copy link

@koganei koganei commented Jun 9, 2021

This PR allows width calculations to be float numbers instead of just integers. It allows for a more uniform distribution of columns and alignment with other grids.

@commit-lint
Copy link

commit-lint bot commented Jun 9, 2021

Bug Fixes

  • core: use allowFloatWidth property to allow float calculations for width (ac78f61)
  • core: use allowFloatWidth property to allow float calculations for width (f172386)

Contributors

marc-khoury-kronos

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@mportuga mportuga changed the title Use allowFloatWidth property to allow float calculations for widths fix(core): use allowFloatWidth property to allow float calculations for widths Jun 9, 2021
@koganei koganei force-pushed the feat/column-float-widths branch from f655438 to f172386 Compare June 9, 2021 14:09
@mportuga mportuga merged commit bb28b2f into angular-ui:master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants