Skip to content
This repository was archived by the owner on Sep 8, 2020. It is now read-only.

Publish to NPM #72

Closed
wants to merge 3 commits into from
Closed

Publish to NPM #72

wants to merge 3 commits into from

Conversation

maxkorp
Copy link
Contributor

@maxkorp maxkorp commented Dec 15, 2014

Fixes #71

This does a few things. First, I added npm-debug.log to the gitignore, just a small accessory commit.
Second, it adds an NPM ignore, so when published to NPM, it doesn't include unneeded files, and only includes the license/readme/dist/package.json files.

This means that by running npm publish (on master, generally speaking), it can first generate the compiled files and then publish them to NPM.

If it's more desirable, I can set up a publish npm task (akin to the bower one) that would let travis handle the building and npm publishing.

@jbro-io
Copy link
Contributor

jbro-io commented Dec 20, 2014

You should be installing with bower, not npm.

@jbro-io jbro-io closed this Dec 20, 2014
@maxkorp
Copy link
Contributor Author

maxkorp commented Dec 22, 2014

Why though? I get that bower is often the go to for dependency management for UI stuff, but hat basically forces me to use Bower for one or two libraries, even though I use NPM for everything else. Plenty of people handle their dependencies with just NPM. Why make that more complicated? You can get Angular on npm, why not an angular addon?

Building a node-webkit application, I can use npm to manage all of my dependencies. Some of my libs are only available on NPM, as they're generally serverside type libraries. Perhaps I might understand more if publishing to NPM carried a lot of overhead, but other than streamlining the publishing output (which I've already done in the above PR) there's really not much to it, a few minutes on a release maybe.

I mean no disrespect, but you've basically just told me "you're doing it wrong" about something very subjective (which of the 2 big package managers to use). Is the angular team doing it wrong as well?

If you'd be at all inclined to reconsider, I'd be more than happy to help maintain the NPM publishing.

@jbro-io
Copy link
Contributor

jbro-io commented Dec 22, 2014

Apologies, perhaps I should have explained further. It's not that "you're doing wrong" it's that publishing for angular-ui repos rely on automated testing and publishing via gulp and the angular-ui-publisher lib. Right now, that library only integrates with bower, but could very well be modified to work with npm as well.

In order to accomplish what you're asking, the publishing library would need to be modified so the tasks you've requested can be automated, rather than managed by an individual.

@maxkorp
Copy link
Contributor Author

maxkorp commented Dec 22, 2014

Ah, that I can handle. I'll take a look at that then. Thanks for the explanation 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish to NPM
2 participants