Skip to content

ie7-8 regexp fall #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ludinov opened this issue Feb 17, 2013 · 2 comments
Closed

ie7-8 regexp fall #24

ludinov opened this issue Feb 17, 2013 · 2 comments

Comments

@ludinov
Copy link

ludinov commented Feb 17, 2013

falls in ie7-8

https://github.com/angular-ui/router/blob/ui-states/src/urlMatcherFactory.js#L76
https://github.com/angular-ui/router/blob/ui-states/src/urlMatcherFactory.js#L77

while ((m = placeholder.exec(pattern))) {
    id = (m[1] != null) ? m[1] : m[2];
    regexp = (m[3] != null) ? m[3] : '[^/]*';

(m[3] != null) works differently in ie7-8 and other browsers ...

@ksperling
Copy link
Contributor

Should be fixed now, can you please retest.

@ludinov
Copy link
Author

ludinov commented Feb 17, 2013

Yup - now it works.
IE7&8 have another problems with deeply nested views - will investigate later..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants