feat(stateDirectives): specify options in ui-sref for $state calls #644
Conversation
|
After a quick review this is definitely more full featured, allowing the options to be watched as a scope object, that's pretty cool. Not exactly sure how necessary it is, but it could be nice. Do you have any real use cases for it? Or was it just because it only took a couple extra lines of code to add that functionality in? Your test case doesn't seem like a great use case (switching url to be absolute on the fly). Also I'm a bit worried about the confusion that users will have about whether they are supplying options for $state.go or $state.href, because they have some same but also some different options. The fact that you use "absolute" in your "parameter change" test makes me think you are utilizing the options to generate the href with $state.href, but I think a lot of people will think they are supplying transitionTo options... Sorry for rambling just trying to give some thoughts... |
|
@timkindberg thanks for the thoughts, they made me think some more on it. My actual use case is #395 -- this is more of a nudge in that direction (remove the double quotes from line 7 and that's one possible implementation). The test cases themselves are pretty arbitrary and were chosen for their easily observable side-effects. As it stands, the parameters are for both One thing I noticed is that it's not very defensive. I put in a couple of specs for "silly" things you could do. Not sure if they're any cause for concern. |
|
Yeah, I don't think this is the route we want to go. What I was contemplating was having a I agree there should be a way to reference states dynamically, and I'm still trying to think of a good syntax to allow that, but this isn't it. Fortunately, if you need it that badly in the meantime, it's pretty trivial to roll your own directive. |
|
Yeeaaaaah.. man. You rock regardless @mfield! |
A slightly different take on #628. Although @tobigit's regex is quite impressive, I thought it might be nice to let angular do more of the heavy lifting.
Not 100% sure about the change to
$StateActiveDirective. Did I understand the second argument to$state.getcorrectly? Also, should I be passingparamsstraight into$$setStateInfo, or should I find a way to resolve parameter inheritance first? I don't immediately see a way to do that without duplicating the logic in$state.transitionTo. With a little more guidance here I'd be glad to add a couple tests to cover this.I would be more inclined to
spyOn($state, 'href')andspyOn($state, 'go')instead of munging arguments and inspecting the side effects. I went with the latter style since it seemed to match the rest of the spec better.