Adapter syntax does not support "controller as" syntax

[GrzegorzzBB]

var match = expression.match(/^(\S+)(?:\s+on\s+(\w(?:\w|\d)*))?$/);

This is regexp used to find controller's scope by given controller name, but it doesn't support "controller as" syntax:
ng-controller="MainCtrl as mainCtrl"

ui-scroll.js 531:
var controller = candidate.attr('ng-controller');
This will make {controller} variable equal MainCtrl as mainCtrl, which you can't define as adapter expression because regexp will fail.

[dhilt]

@GrzegorzzBB I commited one new demo on "controller as" syntax for you, it's available here. I believe it could help you. If not, please let us know...

[GrzegorzzBB]

@dhilt Thank you for your response. I didn't had much time to take a look on it. This seems to work only if mainCtrl controller is bound to ui-scroll parent scope. In my case ui-scroll is nested:
<div ng-controller="MainController as mainCtrl">
<my-custom-list-wrapper>
<div ng-include="getListTemplate()">
<div ui-scroll="item in remoteCollection" adapter="mainCtrl.adapter"></div>
</div>
</div>
</div>

Scopes log:

Desired scope is the yellow one. I can workaround this using some $parent relation, but I like whole idea of on syntax. Just this regexp seems to not work with controller as syntax.

[dhilt]

@GrzegorzzBB thanks! now I think I will be able to see the problem, let me try to solve it...

[mfeingold]

@GrzegorzzBB just checked in changes so that you can use the on syntax for controllers defined with as. Please check it out and let us know if it addresses your issue

[dhilt]

@GrzegorzzBB the issue with nested scopes and "Controller As" syntax should go away after today's commits. Please try the latest source code https://github.com/angular-ui/ui-scroll/blob/master/src/ui-scroll.js. The template you posted above does not need to be modified. If there's still any problem please let us know, post details or create demo.

[dhilt]

@GrzegorzzBB v1.5.2 is released. Please try the latest and reopen the issue if needed.