Skip to content

v1.3.1 #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 5, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@
public
node_modules
temp
/nbproject/private/
/nbproject/private/
local_development
19 changes: 15 additions & 4 deletions Gruntfile.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,15 @@ module.exports = (grunt) ->
grunt.loadNpmTasks 'grunt-contrib-uglify'

grunt.initConfig
packageBower: grunt.file.readJSON('./bower.json')
timestamp: (new Date()).toISOString()
releaseData:
'/*!\n' +
' * <%= packageBower.name %>\n' +
' * <%= packageBower.homepage %>\n' +
' * Version: <%= packageBower.version %> -- <%= timestamp %>\n' +
' * License: <%= packageBower.license %>\n' +
' */\n'
connect:
app:
options:
Expand Down Expand Up @@ -49,11 +58,11 @@ module.exports = (grunt) ->
bare: true
#sourceMap: true

#prepend 'use strict' to the files
concat:
#usestrict:
options:
banner: '(function () {\n\'use strict\';\n'
#prepend 'use strict' and release data to the files
banner:
'<%= releaseData %> \n\n (function () {\n\'use strict\';\n'
footer: '}());'
stripBanners: true
process: (src, filepath) ->
Expand All @@ -71,11 +80,13 @@ module.exports = (grunt) ->
)

dynamic_mappings:
files:
files:
'dist/ui-scroll.js': ['./temp/**/ui-scroll.js']
'dist/ui-scroll-jqlite.js': ['./temp/**/ui-scroll-jqlite.js']

uglify:
options:
banner: '<%= releaseData %>'
common:
files:
'./dist/ui-scroll.min.js': [
Expand Down
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,12 @@ See [index.html](http://rawgithub.com/angular-ui/ui-scroll/master/demo/index.htm

###History

###v1.3.1
* Changed the logic of viewport scroll/padding recalculation (to solve the problem [#8](https://github.com/angular-ui/ui-scroll/issues/8)).
* Splitted test specifications.
* Updated dev-dependencies (package.json).
* Implemented append/prepend methods on the adapter.

###v1.3.0
* Reorganized the repository structure.

Expand Down
2 changes: 1 addition & 1 deletion bower.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "angular-ui-scroll",
"version": "1.3.0",
"version": "1.3.1",
"homepage": "https://github.com/angular-ui/ui-scroll.git",
"description": "AngularJS infinite scrolling module",
"main": "./dist/ui-scroll.js",
Expand Down
10 changes: 9 additions & 1 deletion dist/ui-scroll-jqlite.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
(function () {
/*!
* angular-ui-scroll
* https://github.com/angular-ui/ui-scroll.git
* Version: 1.3.1 -- 2015-08-05T13:39:04.079Z
* License: MIT
*/


(function () {
'use strict';
angular.module('ui.scroll.jqlite', ['ui.scroll']).service('jqLiteExtras', [
'$log', '$window', function(console, window) {
Expand Down
6 changes: 6 additions & 0 deletions dist/ui-scroll-jqlite.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

107 changes: 59 additions & 48 deletions dist/ui-scroll.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
(function () {
/*!
* angular-ui-scroll
* https://github.com/angular-ui/ui-scroll.git
* Version: 1.3.1 -- 2015-08-05T13:39:04.079Z
* License: MIT
*/


(function () {
'use strict';

/*!
Expand Down Expand Up @@ -150,17 +158,17 @@ angular.module('ui.scroll', []).directive('uiScrollViewport', function() {
bottomPadding: function() {
return bottomPadding.paddingHeight.apply(bottomPadding, arguments);
},
insertElement: function(e, sibling) {
return insertElement(e, sibling || topPadding);
},
insertElementAnimated: function(e, sibling) {
return insertElementAnimated(e, sibling || topPadding);
},
bottomDataPos: function() {
return scrollHeight(viewport) - bottomPadding.paddingHeight();
},
topDataPos: function() {
return topPadding.paddingHeight();
},
insertElement: function(e, sibling) {
return insertElement(e, sibling || topPadding);
},
insertElementAnimated: function(e, sibling) {
return insertElementAnimated(e, sibling || topPadding);
}
};
});
Expand Down Expand Up @@ -321,55 +329,58 @@ angular.module('ui.scroll', []).directive('uiScrollViewport', function() {
}
};
adjustBuffer = function(rid, finalize) {
var i, j, len, promises, toBePrepended, toBeRemoved, wrapper;
var promises, toBePrepended, toBeRemoved;
promises = [];
toBePrepended = [];
toBeRemoved = [];
for (i = j = 0, len = buffer.length; j < len; i = ++j) {
wrapper = buffer[i];
switch (wrapper.op) {
case 'prepend':
toBePrepended.unshift(wrapper);
break;
case 'append':
if (i === 0) {
builder.insertElement(wrapper.element);
} else {
builder.insertElement(wrapper.element, buffer[i - 1].element);
}
builder.bottomPadding(Math.max(0, builder.bottomPadding() - wrapper.element.outerHeight(true)));
wrapper.op = 'none';
break;
case 'insert':
if (i === 0) {
promises = promises.concat(builder.insertElementAnimated(wrapper.element));
} else {
promises = promises.concat(builder.insertElementAnimated(wrapper.element, buffer[i - 1].element));
}
builder.bottomPadding(Math.max(0, builder.bottomPadding() - wrapper.element.outerHeight(true)));
wrapper.op = 'none';
break;
case 'remove':
toBeRemoved.push(wrapper);
}
}
return $timeout(function() {
var item, itemHeight, itemTop, k, l, len1, len2, len3, len4, m, n, newHeight, newRow, rowTop, topHeight;
for (k = 0, len1 = toBePrepended.length; k < len1; k++) {
wrapper = toBePrepended[k];
builder.insertElement(wrapper.element);
newHeight = builder.topPadding() - wrapper.element.outerHeight(true);
if (newHeight >= 0) {
builder.topPadding(newHeight);
} else {
viewport.scrollTop(viewport.scrollTop() + wrapper.element.outerHeight(true));
var bottomPos, heightIncrement, i, item, itemHeight, itemTop, j, k, l, len, len1, len2, len3, len4, m, n, newRow, rowTop, topHeight, wrapper;
bottomPos = builder.bottomDataPos();
for (i = j = 0, len = buffer.length; j < len; i = ++j) {
wrapper = buffer[i];
switch (wrapper.op) {
case 'prepend':
toBePrepended.unshift(wrapper);
break;
case 'append':
if (i === 0) {
builder.insertElement(wrapper.element);
} else {
builder.insertElement(wrapper.element, buffer[i - 1].element);
}
wrapper.op = 'none';
break;
case 'insert':
if (i === 0) {
promises = promises.concat(builder.insertElementAnimated(wrapper.element));
} else {
promises = promises.concat(builder.insertElementAnimated(wrapper.element, buffer[i - 1].element));
}
wrapper.op = 'none';
break;
case 'remove':
toBeRemoved.push(wrapper);
}
wrapper.op = 'none';
}
for (l = 0, len2 = toBeRemoved.length; l < len2; l++) {
wrapper = toBeRemoved[l];
for (k = 0, len1 = toBeRemoved.length; k < len1; k++) {
wrapper = toBeRemoved[k];
promises = promises.concat(removeItem(wrapper));
}
builder.bottomPadding(Math.max(0, builder.bottomPadding() - (builder.bottomDataPos() - bottomPos)));
if (toBePrepended.length) {
bottomPos = builder.bottomDataPos();
for (l = 0, len2 = toBePrepended.length; l < len2; l++) {
wrapper = toBePrepended[l];
builder.insertElement(wrapper.element);
wrapper.op = 'none';
}
heightIncrement = builder.bottomDataPos() - bottomPos;
if (builder.topPadding() >= heightIncrement) {
builder.topPadding(builder.topPadding() - heightIncrement);
} else {
viewport.scrollTop(viewport.scrollTop() + heightIncrement);
}
}
for (i = m = 0, len3 = buffer.length; m < len3; i = ++m) {
item = buffer[i];
item.scope.$index = first + i;
Expand Down
8 changes: 7 additions & 1 deletion dist/ui-scroll.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "angular-ui-scroll",
"description": "two way infinite scroll",
"version": "1.3.0",
"version": "1.3.1",
"src": "./src/",
"public": "./public/",
"main": "./dist/ui-scroll.js",
Expand Down
Loading