Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

Third party directives added to ui-select-choices is created 2 times #1000

Closed
hyzhak opened this issue Jun 9, 2015 · 4 comments
Closed

Third party directives added to ui-select-choices is created 2 times #1000

hyzhak opened this issue Jun 9, 2015 · 4 comments

Comments

@hyzhak
Copy link
Contributor

hyzhak commented Jun 9, 2015

Seems ui-select-choices does extra work. Here is example. third party directive in any place is created once but in ui-select-choices it happens twice.
http://plnkr.co/edit/4nmGd7DxkDO6JuvONJ4D?p=preview

@bluemaex
Copy link

Also stumpled upon this bug today. Did you find a way to get around?

@hyzhak
Copy link
Contributor Author

hyzhak commented Jun 22, 2015

no

@user378230
Copy link
Contributor

Related #170 ?

@wesleycho
Copy link
Contributor

#170 is too old, just closed it.

user378230 added a commit to user378230/ui-select that referenced this issue Apr 4, 2016
Previously the template was compiled, edited, and then recompiled. This
was unecessary as the changes we unrelated to the scope and so could be
made before the link function was run.

This change, moves the DOM transformations to the compile function so
the directive does not have to be compiled manually.

Fixes angular-ui#1000
user378230 added a commit that referenced this issue Apr 6, 2016
Previously the template was compiled, edited, and then recompiled. This
was unnecessary as the changes we unrelated to the scope and so could 
be made before the link function was run.

This change, moves the DOM transformations to the compile function so
the directive does not have to be compiled manually.

Fixes #1000
fcaballero pushed a commit to fcaballero/ui-select that referenced this issue Apr 17, 2016
Previously the template was compiled, edited, and then recompiled. This
was unnecessary as the changes we unrelated to the scope and so could 
be made before the link function was run.

This change, moves the DOM transformations to the compile function so
the directive does not have to be compiled manually.

Fixes angular-ui#1000
fcaballero pushed a commit to fcaballero/ui-select that referenced this issue Apr 25, 2016
Previously the template was compiled, edited, and then recompiled. This
was unnecessary as the changes we unrelated to the scope and so could 
be made before the link function was run.

This change, moves the DOM transformations to the compile function so
the directive does not have to be compiled manually.

Fixes angular-ui#1000
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants