Publish ui-select on NPM registry

[mathpere]

Hello,

Would it possible to publish ui-select on NPM registry?

Best.

[ghost]

+1 please!

[brianium]

+1

[dallasclark]

+1

[Myztiq]

+1

[stefan-leye]

+1

[allenm]

+1

[trotman999]

+1

[wurmr]

Yes please, This would make life easier for those of us using webpack.

[qraynaud]

👍

[qraynaud]

It is published on NPM here : https://www.npmjs.com/package/ui-select but it is not up to date…

[sebastien-nicolas]

It would be really great if we could use ui-select's last version (0.12.0) with NPM.
Could you update it on NPM registry please?

[bathos]

Note for folks about to install this via npm -- it's up there, but it may not turn out like you expect. It currently has a bower dependency and uses postinstall for 'bower install'.

[vperron]

cf #982

[bathos]

@vperron: It's sort of like inviting someone into your home, and they come in, but they walk right by you without speaking and start moving furniture in your living room. Their movements are very efficient. They're building something. You’re like "wait, what are y--" but they're really fast and they don't even seem to notice you’re there. In no time, they've built a miniature house inside your house. Finished, they step inside, lock the little door behind them, and just stare at you from a little window with a cold, alien expression that somehow tells you it isn't safe to step any nearer.

Your daughter has started crying.

"What does it want daddy?"

"I don't know, honey. I don't know..."

[idooo]

+1

[benoror]

+1 for supporting CommonJS package management!

Motivation

We are in the process of refactoring an app to support modern JS tooling like NPM, Webpack & ES6.

Code Change

A small change is needed to support CommonJS:

/* commonjs package manager support (eg componentjs) */
if (typeof module !== "undefined" && typeof exports !== "undefined" && module.exports === exports) {
    module.exports = "ui.select";
}

• Source: ui-router release
• Or: UMD (Universal Module Definition)

I tried modifying UI-Select's gulpfile.js:

      .pipe(header(
                '/* commonjs package manager support (eg componentjs) */\n'+
                'if (typeof module !== "undefined" && typeof exports !== "undefined" && module.exports === exports) {\n'+
                '  module.exports = "ui.select";\n'+
                '}\n' +
        '(function (angular) { \n"use strict";\n'))
      .pipe(footer('\n}(angular));'))

but test are throwing this error:

Chrome 44.0.2403 (Windows 7 0.0.0) ERROR
  Uncaught Error: [$injector:nomod] Module 'ui.select' is not available! You either misspelled the module name or forgot to load it. If registering a module ensure that you specify the dependencies as the second argument.
  http://errors.angularjs.org/1.4.3/$injector/nomod?p0=ui.select
  at c:/Users/benoror/Dropbox/github/ui-select/bower_components/angular/angular.js:1958

I'm not sure how to proceed, any help would be appreciated in order to make a PR 😄

Precedents

I have done other PRs for some of my dependencies:

• Support for Webpack + CommonJS Package Manager wix-incubator/angular-tree-control#152
• Support Webpack + CommonJS Package Manager PatrickJS/angular-md5#8
  • commonjs package manager support (fix #8) PatrickJS/angular-md5#9
• commonjs package manager support muratcorlu/angular-urlify#1
• commonjs + bower package manager support tarkanlar/Angular-Urlify#1

Sources

• Using Angular 1.x With ES6 and Webpack by Jesus Rodriguez
• Webpack & Angular by Shawn McKay
• Angular and Webpack for Modular Applications by @kentcdodds
• NPM for Everything

[benoror]

Just as a note, I was able to include it in Webpack + ES6 with:

import ngSanitize from 'angular-sanitize';
import uiselect from 'ui-select';
import 'ui-select/dist/select.css';

/** ... **/

export default angular.module('app.module.xyz', [
   /** ... **/
    ngSanitize,
    'ui.select'
   /** ... **/
  ])
  .name

[nicklasb]

Either way, should it not be called angular-ui-select on npm as well?
Because this could become a name conflict, one cannot ES6-import both ui-select and angular-ui-select using the same import statement.
Unless we all leave bower behind and start using jspm/systemjs/npm, of course. (btw, jspm is quite great).

But in my case, I am developing a component is, currently, equally likely to have its dependencies satisfied via bower and npm. In which case, well, problems arise.

[ebrentnelson]

@benoror You were able to use the existing ui-select npm project and import it into a webpack/Angular project? Sounds like you were able to, but could you share more? When I import it, it just results in an empty object (which is typical of things that are CommonJS ready).

[benoror]

Jus as I mentioned before. I updated the example to include 'angular-sanitize'.

[visnup]

@ebrentnelson I'm using webpack and passing it through exports-loader and inserting in the "ui.select" string:

webpack.config.js

  module: {
    loaders: [
      { test: /ui-select/, loader: 'exports?"ui.select"' },
    ]
  },

and then using it:

angular.module('foo', [ require('ui-select') ])
  //...

[ebrentnelson]

@visnup you just changed my life! That is DOPE!!

[visnup]

@ebrentnelson 👍🏼

[jonathaningram]

What are the chances of the npm version being updated?

[lazychino]

plz do this!

[mkoryak]

I published a fork here:
npm install ui-select-that-was-forked-solely-to-update-npm-version

[benoror]

Should we e-mail [email protected] to ask him to add collaborators to npm package https://www.npmjs.com/package/ui-select/access ? Who should be added? @amcdnl @dimirc @arkarkark?

[mkoryak]

i emailed @dimirc a week ago, so emailing those other guys might be good

[benoror]

Hi Aaron! (@aaronroberson)

Would you kindly add other ui-select's mantainers as collaborators of the
npm package (https://www.npmjs.com/package/ui-select/access), in order to
keep it updated.

Thanks in advance, cheers!

[aaronroberson]

Absolutely, please provide npm usernames.

On Tue, Oct 20, 2015, 8:55 AM Benjamin Orozco [email protected]
wrote:

Hi Aaron! (@aaronroberson)

Would you kindly add other ui-select's mantainers as collaborators of the
npm package (https://www.npmjs.com/package/ui-select/access), in order to
keep it updated.

Thanks in advance, cheers!

On Tue, Oct 20, 2015 at 10:51 AM Misha Koryak [email protected]
wrote:

i emailed @dimirc https://github.com/dimirc a week ago, so emailing
those other guys might be good

—
Reply to this email directly or view it on GitHub
<
https://github.com/angular-ui/ui-select/issues/692#issuecomment-149611826>
.

Sent from my phone (sorry for possible typos)
Benjamin Orozco - benoror.com

—
Reply to this email directly or view it on GitHub
#692 (comment)
.

[benoror]

Feel free to submit a PR for the Docs, remember this is OSS 😄

[yukw777]

@benoror I just realized that even without @aaronroberson 's PR (#932), it still works with browserify. When everything's done, I may make a PR for the docs.

[aaronroberson]

@yukw777 are you using npm require and it still works? Also, my PR
exports the module name so you can do the require directly in the module
definitions.

On Thu, Dec 10, 2015 at 9:30 AM yukw777 [email protected] wrote:

@benoror https://github.com/benoror I just realized that even without
@aaronroberson https://github.com/aaronroberson 's PR (#932
#932), it still works with
browserify. When everything's done, I may make a PR for the docs.

—
Reply to this email directly or view it on GitHub
#692 (comment)
.

[yukw777]

@aaronroberson yeah, i basically did:

require('ui-select');
var app = angular.module('myApp', ['ui.select']);

and it worked. It'd be cleaner with your PR though!

[mkoryak]

@aaronroberson is there any reason why your PR hasnt been merged yet?

[aaronroberson]

My hunch is that it has to do with the fact that there are 182 pending PRs for this project and the Angular-UI team prefers to deprecate a project rather than maintain it. It would be nice if they at least bothered to add individuals to the team that are interested in maintaining the project.

[ranjith19]

What is the status of this now?

[mkoryak]

Same as it was a month ago

[CrlsMrls]

well my friends, there is no one of the almost 200 pull requests being merged since October!!

Let's face it, nobody from the main contributors is maintaining this project anymore. I think we should stop using this. Sadly.

[benoror]

Maybe I will submit a PR to place this badge in the Readme:

oh wait ...

[mkoryak]

I think its time to start a new project, this project tried too do too many things for everyone, and I wouldnt wait to maintain it either.

edit (nevermind, i own some other angular-ui sounding npm package, not this one)

[aaronroberson]

I've published my updates to npm. You can install with npm i --save [email protected]

[aaronroberson]

I've also accepted several PRs into my fork and have published [email protected]. If you would like your PRs accepted and published to npm please send your PR requests to my fork https://github.com/aaronroberson/ui-select and they will be published under the -ar namespace. If you would like to submit your PR to angular-ui and to my fork you are encouraged to do so. If you would like to submit someone else's PR which has already been created against angular-ui, you can follow the instructions below:

Navigate to the fork which has initiated the pull request (pr-fork) and would like to get published to npm under the -ar namespace.
Go to the pull requests page of the initiating fork (pr-fork)
Click New Pull Request button.
The pending pull request(s) should be offered. Select on the left side as the base fork (aaronroberson/ui-select) (IMPORTANT)
Now the View Pull Request button should change to Create Pull Request. Click Create Pull Request button.
Now there should be a pending pull request in aaronroberson/ui-select which I will accept if the following are true:

UPDATED

I've been added as a contributor to this project and can merge PRs directly. To expedite your PRs, please ensure the following:

1. All tests pass.
2. Feature requests retain the nature of the ui-select, selectize and Select2 projects.
3. Merge conflict instructions are provided for merging the current base (master branch) and remote (pull request).
4. Your code is not ambiguous or obscure.

[benoror]

@aaronroberson great, thanks! 👍 gonna try it out asap

[homerjam]

@aaronroberson appreciate the good work - now that you're a contributor is there any chance of reverting to the previous module name (angular-ui-select) on npm?

[aaronroberson]

@homerjam That project is owned by someone else and it would require that we 1) Gain ownership and 2) Update package.json name to 'angular-ui-select' and 3) decommission ui-select on npm. The first step is a blocker at this time.

[homerjam]

Fair enough @aaronroberson, cheers for clarifying.

[mkoryak]

@aaronroberson are you trying to get banned from GitHub? I'll help with that

[aaronroberson]

Those were not intentional and I've deleted them now. Apologies.

[benoror]

Those were not intentional and I've deleted them now. Apologies.

@aaronroberson I actually used your coupon 🙈

[mkoryak]

@aaronroberson you're doing it again :)

What causes this?

[aaronroberson]

I did a bulk invite using Gmail and I think every interaction on GitHub creates a new address for replying through email 🤷🏻‍♂️ I've deleted the post again, and this time I've removed the third-party app from my Google account so it will no longer do this 🤞🏻

Ben, it's a great service I got the interior of my fridge cleaned, cabinets, and windows cleaned in addition to the regular whole house cleaning for only $87+tip. I also got $55 credit for your referral, thanks! Just DON'T do a bulk Gmail invite!!!!

[vperron]

How serious are you dude ?

[mkoryak]

@aaronroberson dude.

[vperron]

Can we think about banning @aaronroberson ?

[aaronroberson]

I had removed the third-party app from Google so these weren't being sent by me anymore. I think every time someone gave their comment to this thread (instead of ignoring it) it triggered their mail system. I reached out to Handy and they said to click the unsubscribe link in the post. I just did that, and have also deleted the posts once again. We'll see. Sorry folks. There's a big unsubscribe button at the bottom of this issue that you can click if you can't lock this thread.

[benoror]

Hilarious *Ben Orozco* benoror.com ( http://benoror.com ) Appointments: calendly.com/benoror ( http://calendly.com/benoror )

…

On Tue, Apr 9 2019 at 7:47 AM, < ***@***.*** > wrote: I had removed the third-party app from Google so these weren't being sent by me anymore. I think every time someone gave their comment to this thread (instead of ignoring it) it triggered their mail system. I reached out to Handy and they said to click the unsubscribe link in the post. I just did that, and have also deleted the posts once again. We'll see. Sorry folks. There's a big unsubscribe button at the bottom of this issue that you can click if you can't lock this thread. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub ( #692 (comment) ) , or mute the thread ( https://github.com/notifications/unsubscribe-auth/AAHRTXTZRK1vY0uKkIhDFVM9HWdUlh8kks5vfJnygaJpZM4DjEeG ).