Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

Tagging without multiple with new tags doesn't works when using angularjs 1.3.2 #890

Open
larrybolt opened this issue Apr 28, 2015 · 12 comments

Comments

@larrybolt
Copy link

When using angularjs 1.3.2 tagging without multiple doesn't work for new items that are not added to the array.
I've also tried editing demo-tagging.html, by replacing the angularjs libraries with following:

<script src="http://ajax.googleapis.com/ajax/libs/angularjs/1.3.2/angular.js"></script>
<script src="http://ajax.googleapis.com/ajax/libs/angularjs/1.3.2/angular-sanitize.js"></script>

And it seems to confirm something changed in the 1.3.2 to break this feature.

I'm really hoping there's an easy fix for this 😞 as this feature was exactly what I needed.

@larrybolt
Copy link
Author

And just trying to use angularjs 1.3.0 on the app I'm working on does run the tagging function, but doesn't seem to pass any arguments such as the new object.

$scope.tagTransform = function (newTag) {
    console.log("new tag", newTag, arguments);
    // ...
  };

@grebett
Copy link

grebett commented May 5, 2015

I've written a quick workaround you can find there.
Not sure it's good enough for a pull request but may do the job for the while.

@BipulKumarChoudhary
Copy link

I am facing the same issue , tagging is not happening with above mentioned code using angularjs 1.3.2

@karptonite
Copy link

I actually see this same problem in 1.3.1 as well. Works fine in 1.3.0.

@guilhermerocha
Copy link

I'm facing the same problem.

@ghost
Copy link

ghost commented May 26, 2015

same problem here
you can reproduce the problem in the official example

http://plnkr.co/edit/m1SQXUxftBLQtitng1f0?p=preview

by changing the angular version in line 21 from
<script src="http://ajax.googleapis.com/ajax/libs/angularjs/1.3.0/angular.js"></script>
to
<script src="http://ajax.googleapis.com/ajax/libs/angularjs/1.3.1/angular.js"></script>
now tagging of a single-select isn't working anymore
i also tried
<script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.4.0-rc.2/angular.min.js"></script>
and it's not working

brianfeister pushed a commit that referenced this issue May 28, 2015
@Sitaxa
Copy link

Sitaxa commented Jun 8, 2015

Same problem here. Any issue ? (1.3.16/angular.js)

@sukantary
Copy link

I'm facing the same problem. Please help

@karptonite
Copy link

This temporary fix worked for me:
#983 (comment)

@LeleDev
Copy link

LeleDev commented Aug 23, 2015

Please make tagging work also without the workaround tagging-label="false"...

@fferraris
Copy link

👍

fredkingham added a commit to openhealthcare/opal that referenced this issue Oct 30, 2015
…i/ui-select#890, using a workaround. Also allow assume tagging by default
@davekr
Copy link

davekr commented Mar 31, 2016

I solved this with older version of ui-select. I am using version 0.11.0. With angular >1.3.2 it works as it's suppoused to and with angular <=1.3.2 you have to set tagging-label to "(new)" explicitly otherwise "undefined" will be shown.

karthicksundararajan added a commit to karthicksundararajan/ui-select that referenced this issue Jul 20, 2016
…orks

Tagging in single select is not working which has been testing in latest version of angular. Here, I've just copied working version of code from uiSelectMultiple directive and removed some code which causes the problem.

All the test has been passed. Examples are working fine

Closes angular-ui#1409, angular-ui#890
kboga pushed a commit to kboga/ui-select that referenced this issue Nov 29, 2016
…orks

Tagging in single select is not working which has been testing in latest version of angular. Here, I've just copied working version of code from uiSelectMultiple directive and removed some code which causes the problem.

All the test has been passed. Examples are working fine

Closes angular-ui#1409, angular-ui#890
kboga pushed a commit to kboga/ui-select that referenced this issue Nov 29, 2016
…orks

Tagging in single select is not working which has been testing in latest version of angular. Here, I've just copied working version of code from uiSelectMultiple directive and removed some code which causes the problem.

All the test has been passed. Examples are working fine

Closes angular-ui#1409, angular-ui#890
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests