Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

fix(focus): prevent focus stealing when clicking on other ui-select element #668

Merged
merged 2 commits into from
Feb 18, 2015

Conversation

dimirc
Copy link
Contributor

@dimirc dimirc commented Feb 16, 2015

  • Fix focus stealing when ui-select is open and clicking on other ui-select

Not working Plunker
Fixed Plunker

Not working Plunker
Fixed Plunker

Fixes #283 , Fixes #253, Fixes #598, Fixes #646

@BP18
Copy link
Contributor

BP18 commented Feb 17, 2015

I don't think this fixes #646. If I open the "Fixed Plunker" and add a regular text input box at the top, I can still reproduce the problem demonstrated in the video in #646.

@dimirc
Copy link
Contributor Author

dimirc commented Feb 17, 2015

@BP18 you are right, I just created this new plunker to reproduce the bug.

Seems like this PR right now is only fixing the focus problem when clicking on other ui-select controls. I'll need to look on this other issue too so that we could resolve it also on this PR

@dimirc
Copy link
Contributor Author

dimirc commented Feb 17, 2015

@BP18 take a look now

@BP18
Copy link
Contributor

BP18 commented Feb 17, 2015

Played around with the fixed Plunker and it looks good now. Thanks!

dimirc added a commit that referenced this pull request Feb 18, 2015
fix(focus): prevent focus stealing when clicking on other ui-select element
@dimirc dimirc merged commit 86689b9 into master Feb 18, 2015
@dimirc dimirc deleted the fix-focus-steal branch February 18, 2015 03:20
tborres added a commit to b2io/ui-select that referenced this pull request Jun 26, 2019
When the user clicks on another input the focus should remain in the new
input and not immediately return to the ui-select.

Heavily based on angular-ui#668
tborres added a commit to b2io/ui-select that referenced this pull request Jun 26, 2019
When the user clicks on another input the focus should remain in the new
input and not immediately return to the ui-select.

Heavily based on angular-ui#668
tborres added a commit to b2io/ui-select that referenced this pull request Jun 26, 2019
When the user clicks on another input the focus should remain in the new
input and not immediately return to the ui-select.

Heavily based on angular-ui#668
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants