Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

chore(refactor): split code into multiple files #684

Merged
merged 1 commit into from
Feb 20, 2015
Merged

Conversation

dimirc
Copy link
Contributor

@dimirc dimirc commented Feb 19, 2015

I think it's time to split the code into different files to get more organized. Basically I split each main directive and service into different files and did a small change on the gulpfile to concat them when building.

I guess that this split might also help to avoid people pushing changes to /dist/select.js file and do the PR on the specific /src files

This is how it will look:
image

Later we should also reorganize the themes folders (check #186)

Let me know your opinion

Related to: #649

@dimirc
Copy link
Contributor Author

dimirc commented Feb 20, 2015

@brianfeister @JeffGreat @starf @homerjam sorry to spam you, but as I see you active on this repo, can you give me your opinion on this PR? I know this will break most PRs that aren't merged but I think this will help to start organizing better all the project.

PD: This PR is failing because I merged #651 (support for sort for multiselect) today and I should becase and create a new file uiSelectSortDirective.js

@dimirc dimirc force-pushed the refactor-split-code branch 2 times, most recently from 6625fbc to 79d6455 Compare February 20, 2015 04:12
@dimirc dimirc force-pushed the refactor-split-code branch from 79d6455 to 8d7706f Compare February 20, 2015 04:14
@dimirc
Copy link
Contributor Author

dimirc commented Feb 20, 2015

I rebased this PR to last master, with a new file for sort directive:
image

@starf
Copy link

starf commented Feb 20, 2015

Don't count me as active, just a user trying to fix some of my issues while migrating from ui-select2. Looks to me to be much more manageable & readable like this.

@homerjam
Copy link
Contributor

I guess I'm newly active! I think splitting up the files will certainly make things easier

@brianfeister
Copy link

This looks good to me @dimirc. Would be a great time to think about how we generate distributions, whether the theme files can be broken out per the discussions in #175, #186, #529... obviously the scope of that is bigger, however. My company just made the decision to move to Angular Material over Bootstrap, so it would be great to both include that as a new theme and also come up with a strategy for breaking out dependencies and having a way to reference different CSS and angular templates per theme #438

dimirc added a commit that referenced this pull request Feb 20, 2015
chore(refactor): split code into multiple files
@dimirc dimirc merged commit 6e81746 into master Feb 20, 2015
@dimirc dimirc deleted the refactor-split-code branch February 20, 2015 22:08
@dimirc dimirc added this to the 0.10.x milestone Feb 20, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants