This repository was archived by the owner on Sep 8, 2020. It is now read-only.
fix(priority): lower priority to make it work with ngIf #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for doing this. Will get this merged and release a new version later tonight. |
|
Glad to hear it! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ngIf priority is 600 so I've lowered uiTinymce's to 599. I had a look at some other angular directive but apart from ngIf, I can't see any other one that could be a problem.
I also wanted to add tests for #146 to make sure this change doesn't introduce a regression but wasn't able to reproduce the issue it fixed back then. Anyway, 599 is still pretty high so I guess it's ok.
fix #241