-
Notifications
You must be signed in to change notification settings - Fork 12k
safety-worker.js: same source code as ngsw-worker.js #24678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @000panther, I'm going to transfer this to the CLI repo - as far as I can tell, this seems to be a problem with the CLI service worker build process. The |
Thanks! I am now serving the file you mentioned as safety-worker.js, and it works perfectly! Would be awesome to get this fixed and have correct funtionality out of the box again. |
… contents Previously, `safety-worker.js` and `worker-basic.min.js` contained incorrect data due to an incorrect path. Closes angular#24678
… contents Previously, `safety-worker.js` and `worker-basic.min.js` contained incorrect data due to an incorrect path. Closes angular#24678
… contents Previously, `safety-worker.js` and `worker-basic.min.js` contained incorrect data due to an incorrect path. Closes #24678
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Which @angular/* package(s) are the source of the bug?
service-worker
Is this a regression?
No
Description
We are currently trying to get rid of an old service worker using the safety-worker.js. While writing the corresponding scripts for replacing the ngsw-worker.js with the safety-worker.js I noticed that the contents of the files are the same.
I checked the source of https://github.com/angular/angular/tree/15.1.x/packages/service-worker to see if this change might be intentional and the safety-worker.js mentioned there is a small file containing few lines of code.
Out of curiosity i checked the safety-worker.js of angular io - same as the ngsw-worker.js!
https://angular.io/safety-worker.js
https://angular.io/ngsw-worker.js
This seems like an issue. If this is the expected behaviour, the documentation does not mention it.
Please provide a link to a minimal reproduction of the bug
https://github.com/000panther/service-worker-issue
Please provide the exception or error you saw
No response
Please provide the environment you discovered this bug in (run
ng version
)Anything else?
Can I use the safety-worker.js from the service-worker repository as a workaround for now?
The text was updated successfully, but these errors were encountered: