-
Notifications
You must be signed in to change notification settings - Fork 12k
-prod build fails, repro. on blank (ng new) project: looking for .map files #888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
reproduced with 0.0.39 and 0.0.37, so the hypothesis of an upstream dep bug looks more plausible. It does not happen with 0.0.34 (but 0.0.34 is apparently the last version which does not create bundles). Current client workaround: downgrade to 0.0.34 |
I have this same issue with version 1.0.0-beta.0 |
Duplicate of #847. Will be picked up later today. |
I have same problem
|
@SergeySolonko see #847 for many more details and a potential fix. |
Is this still happening with new projects? The logs here show |
Also, can you verify that both the local and global |
@filipesilva this isn't a new project, but i can confirm that, using 1.0.0-beta.5 (both global and local) with the vendorNpmFiles configuration shown below results in ng not copying a subset of the vendor JS files which we load via index.html (shown on the right of the image): It does copy these in a non-prod build. |
@filipesilva I tested it with a new project here's what I found:
errors during build:
then in the browser:
Note: also it's worth mentioning that but with an old project or new I'm still having problem with libraries. |
@sgbeal the prod builds cannot bundle js files defined in script tags in |
@sgbeal I don't see how this issue related to #951 (comment). Can you elaborate? |
Because in trying to resolve #888, the closest i got to a resolution was the behaviour described in #951. (And only got that far via an explicit "import 'blah'" of all the 3rd-party JS, instead of importing it via index.html.) i still can't get a working -prod build on any version newer than 0.0.34 (the last version which didn't do bundling). |
Ah I reread it a couple of times and I think I understand. Your previous examples showed errors on user libs, not the base script ones. Your user libs you must load via systemjs, but es6-shim and systemjs should be loaded automatically. Very odd that they're 404'ing. On a brand new project the prod build loads it. I need to investigate this further. |
I know I asked before, but please tell me again so I can try to debug: what exact version are you using when that happens? Global install and local install. |
i've tried with local 0.0.39, 1.0.0-beta.1, and beta.5. Global... i don't recall what that machine has and won't have access to it again until Monday. The exact result varies widely, from the .map.js not being found (despite using +(js|map.js) in all my wildcards), to a blank page with no errors (as described in #951), to 404'ing of the es6 shims and systemjs, depending, seemingly, on the time of day, phase of the moon, and the temperature. For one particular run, which i could not reproduce later, it bundled (apparently) properly but failed to load the app because bootstrap was being loaded before jquery (despite their import order being correct in index.ts), causing an exception from some bootstrap component. So close, yet so very far... This morning i ran multiple attempts with beta.1 and .5, along with various versions of systemjs (.26-29), and eventually gave up and went back to 0.0.34 and systemjs .27 (which is where we'll stay, at least until our project launch week after next, after which i hope to have more time/budget to investigate build infrastructure alternatives). |
It might be a problem with the local/global mismatch. The upgrade process isn't very straightforward right now, but downgrading is not really supported at all. I've never seen the 404 for systemjs/es6-shim while trying to repro with global and local |
i will try that on Monday. Sending myself a reminder now. |
Still same
|
@davidrensh see #847 (comment) for a solution to your problem. |
Regarding my comment from 5 days ago (retrying this with various global/local versions): i have been asked by management not to invest any more time in trying to update our build infrastructure, which means we'll be sticking with 0.0.34 until (at least) our initial release (next week). Whether or not there will be project-level interest in resp. budget for pursuing build-level improvements or replacements after that is unknown. |
@sgbeal I understand. Dealing with the ebb and flow of beta (and alpha when started!) tooling software is very time consuming, exponentially so in more complex projects. |
ahoy! It turns out that the requirement for Windows admin rights in Broccoli is not allowed at our customer's site, so i tried a newer ng version where that is fixed... with ng beta.6 and systemjs 0.19.31, the behavior described in this ticket has disappeared. We can now build using |
@sgbeal I'm glad to hear that! Since you're using it on a real environment I have to warn you to this current critical issue in beta.6 #1092. I think the best way for you to get around it is to not use the new router which should be fine because you're using the old router I believe. I'd also like tell you that we now have an upgrade guide and a changelog which should help when upgrading projects. |
👍 |
Doh. No, we're using the new (RC1) router. Thanks for the head's up. So far we haven't seen that problem (and i'll cross my fingers that the guy doing the code review on my copy doesn't run into it). |
We're waiting for a new router release that fixes it, which should be soon, and then we'll cut a beta.7 release. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
windows 10 and Linux (some RHEL variant - i haven't got login access to verify which)
ng --version
. If there's nothing outputted, pleaserun in a Terminal:
node --version
And paste the result here.
node versions 6.1.0, 5.10.1
ng 1.0.0-beta.1 and beta.5
Repro steps. Was this an app that wasn't created using the CLI? What change did you
do on your code? etc.
also tested explicitly with versions 1.0.0-beta.1 and beta.5.
This is breaking our current project, where we distinguish between prod and dev builds (different functionality imported via environment.XXX.ts).
The log given by the failure. Normally this include a stack trace and some
more information.
happens whether or not we use a global installation of ng.
this worked last week - i did -prod builds at least 15 times on Thursaday. Friday the build server started flaking out and today i could not reproduce it until i removed node_modules and reinstalled it. Thus i suspect it's caused by an updated upstream dependency.
The text was updated successfully, but these errors were encountered: