Skip to content

fix(@schematics/angular): ast utils - handle NgModule with no newlines #12521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

vikerman
Copy link
Contributor

@vikerman vikerman commented Oct 9, 2018

Exposed in Google where the formatting is different. Check for null before using regex match result.

@vikerman vikerman added the target: patch This PR is targeted for the next patch release label Oct 9, 2018
@vikerman vikerman requested a review from kyliau October 9, 2018 06:01
@vikerman vikerman force-pushed the ast-fix branch 2 times, most recently from ac61c41 to f9fb6fe Compare October 9, 2018 06:59
@vikerman vikerman changed the title fix(@schematics/angular): fix null pointer exception in ast utils fix(@schematics/angular): ast utils - handle NgModule with no newlines Oct 9, 2018
Exposed in Google where the formatting is different. Check for null before using a regex match result.
@vikerman vikerman merged commit e3f56eb into angular:master Oct 9, 2018
vikerman added a commit that referenced this pull request Oct 9, 2018
#12521)

Exposed in Google where the formatting is different. Check for null before using a regex match result.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants