-
Notifications
You must be signed in to change notification settings - Fork 12k
feat(@ngtools/webpack): Automatically bundle module workers #12575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@ngtools/webpack): Automatically bundle module workers #12575
Conversation
bd0d14f
to
1960433
Compare
Supports new Worker(...,{type:module}) using github.com/googlechromelabs/worker-plugin
1960433
to
0a337ef
Compare
I've looked into this briefly, and in order to get this in, we'll need at least the following:
|
Hi @IgorMinar - just clarifying:
|
Design doc (requires explicit sharing with individuals: https://docs.google.com/document/d/10Ok6pn6L8VoJUys6shqSYKDSRxmu1fM2hAix7PFg4oQ/edit ) |
Thanks @alexeagle. Please let me know if there's anything that needs clarification or that I can help out with. I've spoken to a fair number of folks about this and there's a lot of excitement around getting it merged. |
additional input into the design discussion: https://www.npmjs.com/package/worker-loader that loader seems too magical and webpack specific, I prefer @developit's approach more. |
Hi @developit! This PR has merge conflicts due to recent upstream merges. |
Merge conflicts resolved. |
@developit I don't want this to get lost - but Igor has a checklist above of things we need to be able to merge this. Do you have time to do some or all of those things? Otherwise we need to find someone else to get it over the finish line. |
@developit @alexeagle - this would be a cool feature and would love to see it land. Any plan to move forward with this or any help needed? I can commit some time to help out wherever needed to get it over the finish line. |
@LanceEa, we're working on landing this. |
why was this closed? |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This pull request adds support for automatic bundling of module Workers using worker-plugin.
In essence, it teaches Angular CLI to compile this standard browser syntax:
... into this optimized output, bundling the worker code as if it were a split point:
/cc @robwormald