Skip to content

fix(@schematics/angular): explicitly set standalone:false #28642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2024
Merged

fix(@schematics/angular): explicitly set standalone:false #28642

merged 2 commits into from
Oct 16, 2024

Conversation

jkrems
Copy link
Contributor

@jkrems jkrems commented Oct 15, 2024 •
edited
Loading

Since the new default for standalone is true, any place that previously omitted the value to get an implicit false now needs to set it to false explicitly.

See: angular/angular#58169

@angular-robot angular-robot bot added area: build & ci Related the build and CI infrastructure of the project area: @schematics/angular labels Oct 15, 2024
@jkrems jkrems requested a review from clydin October 15, 2024 18:13
@jkrems jkrems added the target: patch This PR is targeted for the next patch release label Oct 15, 2024
@jkrems jkrems force-pushed the jk-explicit-standalone branch from 477dc8c to cf33d0e Compare October 15, 2024 18:29
@jkrems jkrems marked this pull request as ready for review October 15, 2024 18:29
@angular-robot angular-robot bot removed the area: build & ci Related the build and CI infrastructure of the project label Oct 15, 2024
@jkrems jkrems mentioned this pull request Oct 15, 2024
Merged
1 task
@jkrems jkrems force-pushed the jk-explicit-standalone branch from cf33d0e to 6f28309 Compare October 15, 2024 18:38
@jkrems
Copy link
Contributor Author

jkrems commented Oct 15, 2024

Updated to apply the explicit false consistently for component, directive, and pipe - matching the default flip in core.

@alan-agius4
Copy link
Collaborator

Not: can you cherry-pick the commit from #28634 so that we ran the full snapshot suite in CI?

@jkrems jkrems force-pushed the jk-explicit-standalone branch from 6f28309 to b1ff31c Compare October 15, 2024 20:11
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Oct 15, 2024
@jkrems
Copy link
Contributor Author

jkrems commented Oct 15, 2024

Included the angular update commit in the PR again to ensure the post-upgrade state is tested.

@jkrems
Copy link
Contributor Author

jkrems commented Oct 15, 2024

🍏 💚 🟢 !

@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Oct 16, 2024
alan-agius4
alan-agius4 approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Oct 16, 2024
@alan-agius4 alan-agius4 removed the request for review from clydin October 16, 2024 07:03
@jkrems jkrems merged commit 208d2d5 into angular:main Oct 16, 2024
44 checks passed
@jkrems jkrems deleted the jk-explicit-standalone branch October 16, 2024 14:56
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project area: @schematics/angular target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkrems @alan-agius4 @angular-robot