fix(@angular/build): prevent full page reload on HMR updates with SSR enabled #29381
+37
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: patch
alan-agius4
added
the
action: review
alan-agius4
force-pushed
the
hmr-prevent-reload
branch
3 times, most recently
from
dfd4582 to
96e21f5
Compare
… enabled This commit resolves an issue where HMR would incorrectly trigger a full page reload when used with SSR. Closes angular#29372
alan-agius4
force-pushed
the
hmr-prevent-reload
branch
from
96e21f5 to
3fe3006
Compare
clydin
approved these changes
Jan 17, 2025
alan-agius4
added
action: merge
|
The changes were merged into the following branches: main, 19.1.x |
1 task
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit resolves an issue where HMR would incorrectly trigger a full page reload when used with SSR.
Closes #29372