-
Notifications
You must be signed in to change notification settings - Fork 12k
fix(@angular/cli): fix relative link to README not working on npm repo #29496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The link to the README was relative, which caused it to break when viewed on the npm repository. The link has been updated to an absolute URL to ensure it works properly. Closes angular#29489
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
The changes were merged into the following branches: main, 19.1.x |
The link to the README was relative, which caused it to break when viewed on the npm repository. The link has been updated to an absolute URL to ensure it works properly. (cherry picked from commit 6f9a764)
It doesn't fix the bug in the npm repo :( The link is not updated. Is the npm repo updated when the GitHub repo is? @alan-agius4 |
As I mentioned in my issue, something weird is going on. The link never was relative on NPM, even though it was in Git. I suspect that some script that we cannot see in the repo manipulates the URL before publishing to NPM. |
This still needs to be released on NPM. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The link to the README was relative, which caused it to break when viewed on the npm repository. The link has been updated to an absolute URL to ensure it works properly.
Closes #29489
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information