Skip to content

fix(@angular/build): properly resolve transitive external dependencies in vite-dev-server #30059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025

Conversation

alan-agius4
Copy link
Collaborator

This fix ensures that transitive external dependencies are correctly recognized and excluded during development builds with the Vite dev server. Previously, some dependencies were mistakenly bundled.

Closes #30048

…s in vite-dev-server

This fix ensures that transitive external dependencies are correctly recognized and excluded during development builds with the Vite dev server. Previously, some dependencies were mistakenly bundled.

Closes angular#30048
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Apr 8, 2025
@alan-agius4 alan-agius4 marked this pull request as ready for review April 8, 2025 07:03
@alan-agius4 alan-agius4 requested a review from clydin April 8, 2025 07:03
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 8, 2025
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 10, 2025
@alan-agius4 alan-agius4 merged commit 6e6315d into angular:main Apr 10, 2025
35 checks passed
@alan-agius4 alan-agius4 deleted the vite-external-deps branch April 10, 2025 16:37
@alan-agius4
Copy link
Collaborator Author

The changes were merged into the following branches: main, 19.2.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/build target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No longer includes externalDependencies in esbuild exclusions
2 participants