Skip to content

feat(@angular/cli): allow comments in .angular-cli.json #9615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat(@angular/cli): allow comments in .angular-cli.json #9615

wants to merge 1 commit into from

Conversation

thorn0
Copy link

@thorn0 thorn0 commented Feb 13, 2018

Also allow trailing commas and unquoted object keys.

Closes #5610

@Brocco Brocco requested a review from hansl February 13, 2018 20:34
@hansl
Copy link
Contributor

hansl commented Feb 13, 2018

We already have our own Json parser that supports those (basically Json5 support, and has AST with positioning): https://github.com/angular/devkit/tree/master/packages/angular_devkit/core/src/json

@thorn0
Copy link
Author

thorn0 commented Feb 14, 2018

@hansl Okay, I used it.
Unfortunately, it doesn't support trailing commas, but I guess I'll open a separate issue or a PR for that. Comments are a bigger issue anyways.

@thorn0
Copy link
Author

thorn0 commented Feb 16, 2018

Updated devkit to 0.4.0 to get support for trailing commas.

@thorn0
Copy link
Author

thorn0 commented Feb 16, 2018

Okay, I'm not sure how to update devkit properly. Seems like it's not that simple and shouldn't be part of this PR. So I'm leaving this PR as is.

@thorn0
Copy link
Author

thorn0 commented Feb 27, 2018

Rebased it onto master. @hansl Please have a look.

@clydin
Copy link
Member

clydin commented Apr 4, 2018

Closing as 6.0 has a new configuration system which brings support for comments.

@clydin clydin closed this Apr 4, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow comments in .angular-cli.json
4 participants