Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(ngPluralize): Use "other" pluralization key as a fallback #10195

Closed
wants to merge 1 commit into from
Closed

fix(ngPluralize): Use "other" pluralization key as a fallback #10195

wants to merge 1 commit into from

Conversation

Sija
Copy link

@Sija Sija commented Nov 23, 2014

With languages having optional keys like few or many it's handy to use other as a fallback instead of defining all of the translation keys (in which some may be repeated) in when attribute of ng-pluralize.

Refs #7774

Verified

This commit was signed with the committer’s verified signature.
scala-steward Scala Steward
Refs #774
@googlebot
Copy link

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@Sija Sija changed the title Use "other" pluralization key as a fallback fix(ngPluralize): Use "other" pluralization key as a fallback Nov 23, 2014
@Sija
Copy link
Author

Sija commented Nov 23, 2014

I've signed the CLA from my gmail address.

@googlebot
Copy link

CLAs look good, thanks!

@Sija
Copy link
Author

Sija commented Nov 24, 2014

As agreed in #7774 better solution is needed, thus I'm closing this PR.

@Sija Sija closed this Nov 24, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants