Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix (ngPluralize): generate a warning when being asked to use a rule tha... #10284

Closed
wants to merge 1 commit into from

Conversation

marclaval
Copy link
Contributor

...t is not defined

Following discussions in #10207, it seems that the best solution is to use $log.debug as it is the only log level that can be disabled in production.

@googlebot
Copy link

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@marclaval marclaval force-pushed the issue10207 branch 2 times, most recently from 0a54f8c to 84c262d Compare December 1, 2014 18:20
@gkalpak
Copy link
Member

gkalpak commented Dec 2, 2014

BTW, I didn't get the impression that the "verdict" was to use debug() instead of warn().
I thought it was to use warn() and add support for setting the logging level in $logProvider 😄
@lgalfaso: So, what's the plan ?

watchRemover = scope.$watch(whensExpFns[count], updateElementText);
var whenExpFn = whensExpFns[count];
if (isUndefined(whenExpFn)) {
$log.debug("ngPluralize: no rule defined for '" + count + "' in " + whenExp);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also add watchRemover = noop;
also, it looks like the element text is not updated (it should be set to '')

@lgalfaso
Copy link
Contributor

lgalfaso commented Dec 4, 2014

also, please check that the commit message follow the conventions (if you run init-repo.sh, the check is added)

@lgalfaso lgalfaso added this to the 1.3.7 milestone Dec 4, 2014
@caitp caitp modified the milestones: 1.3.7, 1.3.8 Dec 9, 2014
@pkozlowski-opensource pkozlowski-opensource modified the milestones: 1.3.8, 1.3.7 Dec 9, 2014
@petebacondarwin petebacondarwin modified the milestones: 1.3.7, 1.3.8 Dec 15, 2014
@btford btford modified the milestones: 1.3.8, 1.3.9 Dec 19, 2014
@lgalfaso
Copy link
Contributor

lgalfaso commented Jan 2, 2015

landed as c66b4b6

@lgalfaso lgalfaso closed this Jan 2, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants