Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

refact($SnifferProvider): use existing var "bodyStyle" instead of doc.body.style #10602

Closed

Conversation

LeonardoBraga
Copy link
Contributor

No description provided.

@lgalfaso
Copy link
Contributor

Hi! I do not want to be rude, but is there any reason why you keep on opening and closing this issue?

@LeonardoBraga
Copy link
Contributor Author

@lgalfaso Hi, not being rude at all, and my apologies for that, the problem is that Travis is failing the PR without any reason. If you check the logs, you see the that same build job works sometimes and fails later. I searched about a way to re-start Travis and the only answer I found was closing and re-opening the PR. I had to do the same thing with #10601 until Travis allowed it to go.

Newbie here, so if there's a better way of doing this, please just let me know.

@LeonardoBraga
Copy link
Contributor Author

@lgalfaso It happened again. Is there a better way of working around this without closing and reopening the PR?

@pkozlowski-opensource
Copy link
Member

@LeonardoBraga you can amend and force-push a new commit

@lgalfaso
Copy link
Contributor

and do not worry to much about Travis, it is going thru some bad days

@LeonardoBraga
Copy link
Contributor Author

Thanks @pkozlowski-opensource and @lgalfaso. So, should I leave it as is or keep force-pushing until it passes?

@caitp
Copy link
Contributor

caitp commented Dec 30, 2014

Just leave it please, if it's failing due to flakes (it is)

@LeonardoBraga LeonardoBraga deleted the refactor-sniffer-provider branch January 1, 2015 17:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants