-
Notifications
You must be signed in to change notification settings - Fork 27.4k
chore(npm): Make require()-able as part of publish script #10731
Conversation
@petebacondarwin I'd like to get this into the release today. Just going to test it real quick. That cool with you? |
so, on my system, the |
Not sure I follow. I'm not super familiar with sed tbh, but the deleteJsonProp function is using |
yes, I thought you added it, didn't check the diff =) @IgorMinar do you know if we were using that utility before and it worked right on jenkins? |
wait, it is added in the diff :< hmmm |
Oh, I should probably just remove -e, no? |
Just pushed another commit combining the flags. I think that is right... |
no, you definitely don't want to combine the flags... here's an idea, just leave it as it was before and delete the package.json-e if it exists, that probably is fine |
Sorry, I don't know what you mean by that. |
.. if the file exists ( |
well, I guess this won't make it for 1.3.9 :( sorry man. |
...or maybe it will, we'll see :> |
I think this should be correct. Apparently some versions of sed require a suffix be passed to Fingers crossed! :) |
sed is well outside of my comfort zone. If you two are happy with that then so am I. |
just tested with the latest commit, looks good here |
lgtm~ |
eh pete, should we backport this? I guess future 1.3 releases would want it too |
Sweet! |
@caitp - let's put it in 1.4 and 1.3 but not 1.2 OK? |
(This has not been tested locally with browserify --- but it should work! If it doesn't, please file a bug rather than just leaving a comment on this commit :) Closes #10731
it is done~ |
thank you guys :) |
I understand that there might be a problem with this? |
@petebacondarwin Yea we realized some shortcomings. #10732 now has the correct, improved version. |
(This has not been tested locally with browserify --- but it should work! If it doesn't, please file a bug rather than just leaving a comment on this commit :) Closes angular#10731
Deletes main field of package.json and creates index.js that is CommonJS compatible
/cc @caitp