Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

chore(npm): Make modules Browserify compatible #10732

Closed
wants to merge 13 commits into from
Closed

chore(npm): Make modules Browserify compatible #10732

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
907dae1
chore(nom): Make modules Browserify compatible
bclinkinbeard Jan 13, 2015
736f6c4
Export module name only
bclinkinbeard Jan 13, 2015
62b538c
chore(npm): Pipe to index.js, duh.
bclinkinbeard Jan 13, 2015
706b0ce
chore(npm): Better way to initialize index.js
bclinkinbeard Jan 13, 2015
156ca4c
chore(npm): Add angular peer dependency where appropriate
bclinkinbeard Jan 13, 2015
b4a052d
chore(npm): Handle special case of angular-mocks module(s)
bclinkinbeard Jan 13, 2015
5b5d50c
chore(npm): Remove errant code gen line
bclinkinbeard Jan 13, 2015
24dfc82
chore(npm): Use 2 spaces in package.json, not a tab
bclinkinbeard Jan 13, 2015
8f5bb24
chore(npm): List new utility function
bclinkinbeard Jan 14, 2015
e8b9b7a
chore(npm): Remove peerDependencies generation
bclinkinbeard Jan 14, 2015
1916264
Updating to return the module for everything but angular and angular-…
bclinkinbeard Jan 15, 2015
b40fe18
Clean up and allowing use of require('angular-mocks/ngMock').name
bclinkinbeard Jan 23, 2015
ed8489a
chore(npm): Return module name for all but angular and angular-mocks
bclinkinbeard Feb 18, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions scripts/bower/publish.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,29 @@ function prepare {
replaceJsonProp "bower.json" "angular.*" ".*" "$NEW_VERSION"
replaceJsonProp "package.json" "version" ".*" "$NEW_VERSION"
replaceJsonProp "package.json" "angular.*" ".*" "$NEW_VERSION"
deleteJsonProp "package.json" "main"

echo "-- Adding CommonJS index file"
if [ -f "index.js" ]
then
rm index.js
fi

touch index.js
echo "require('./$repo');" >> index.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of removing index.js, touching it and then appending to it, you could just do this:

echo "require('./$repo');" > index.js --- that would shave off a few lines of code and be a bit easier to read

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, done.

echo "" >> index.js
echo "module.exports = $repo;" >> index.js
if [ $repo == "angular" ]
then
echo "module.exports = angular;"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't you need to pipe these echos to index.js with >>?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! Fixed.

else
# convert to module names (angular-animate >> ngAnimate)
suffix=`echo $repo | cut -c9-`
first=`echo $suffix | cut -c1 | sed -e 'y/abcdefghijklmnopqrstuvwxyz/ABCDEFGHIJKLMNOPQRSTUVWXYZ/'`
tail=`echo $suffix | cut -c2-`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure to comment these lines clearly to indicate that you're transforming the repo name into a module name, alright?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, good idea.


echo "module.exports = 'ng$first$tail';"
fi

git add -A

Expand Down
6 changes: 6 additions & 0 deletions scripts/utils.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,12 @@ function replaceJsonProp {
replaceInFile $1 '"('$2')"[ ]*:[ ]*"'$3'"' '"\1": "'$4'"'
}

# deleteJsonProp(jsonFile, property)
# - restriction: property needs to be on a single line!
function deleteJsonProp {
sed -i '' -e /\"$2\"\:/d $1
}

# replaceInFile(file, findPattern, replacePattern)
function replaceInFile {
sed -i .tmp -E "s/$2/$3/" $1
Expand Down