-
Notifications
You must be signed in to change notification settings - Fork 27.4k
fix(docs/guide/component): wrong $componentController usage #14092
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
|
||
beforeEach(module('simpleComponent')); | ||
|
||
beforeEach(inject(function($rootScope, $componentController) { | ||
scope = $rootScope.$new(); | ||
componentController = $componentController; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is better to keep the original name of the service.
Name the variable $componentController
and inject it as _$componentController_
.
@ptgamr, thx ! Could you, please, address my comment and ping me ? |
@ptgamr, I see you tried to use the correct commit message format 👍
(Adding |
@gkalpak I've updated the PR. Thanks for your comment! |
Thanks @gkalpak 👍 |
#14091