Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(docs/guide/component): wrong $componentController usage #14092

Closed
wants to merge 1 commit into from

Conversation

ptgamr
Copy link
Contributor

@ptgamr ptgamr commented Feb 20, 2016

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@ptgamr
Copy link
Contributor Author

ptgamr commented Feb 20, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!


beforeEach(module('simpleComponent'));

beforeEach(inject(function($rootScope, $componentController) {
scope = $rootScope.$new();
componentController = $componentController;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to keep the original name of the service.
Name the variable $componentController and inject it as _$componentController_.

@gkalpak
Copy link
Member

gkalpak commented Feb 20, 2016

@ptgamr, thx ! Could you, please, address my comment and ping me ?

@gkalpak gkalpak added this to the Purgatory milestone Feb 20, 2016
@gkalpak gkalpak self-assigned this Feb 20, 2016
@gkalpak
Copy link
Member

gkalpak commented Feb 20, 2016

@ptgamr, I see you tried to use the correct commit message format 👍
If you want to go the extra mile, you can change it to something like:

docs(guide/component): fix `$componentController` usage

Fixes #14091

(Adding Fixes/Closes #XYZ at the end, closes the related issues automatically when merging the PR.)

@ptgamr
Copy link
Contributor Author

ptgamr commented Feb 21, 2016

@gkalpak I've updated the PR. Thanks for your comment!

@gkalpak
Copy link
Member

gkalpak commented Feb 22, 2016

Backported to v1.5.x as 2dda75b.
Thx @ptgamr !

@ptgamr
Copy link
Contributor Author

ptgamr commented Feb 22, 2016

Thanks @gkalpak 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants