Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Docs componentrouter install & deprecation #14717

Closed
wants to merge 1 commit into from
Closed

Docs componentrouter install & deprecation #14717

wants to merge 1 commit into from

Conversation

Narretz
Copy link
Contributor

@Narretz Narretz commented Jun 6, 2016

No description provided.

@Narretz Narretz added this to the 1.5.7 milestone Jun 6, 2016
@Narretz Narretz force-pushed the docs-componentrouter-install branch from d17acb9 to c936f66 Compare June 6, 2016 10:44
petebacondarwin
petebacondarwin reviewed Jun 6, 2016
View reviewed changes
docs/content/guide/component-router.ngdoc
@@ -5,6 +5,11 @@

# Component Router

<div class="alert alert-danger">
**Deprecation Notice:** The Component Router (ngComponentRouter module) has been deprecated and will not receive further updates.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should be saying...

This implementation of the component router has been deprecated ...

So that it doesn't make it sound like there will never be a component router

@Narretz Narretz force-pushed the docs-componentrouter-install branch from c936f66 to 1eb6300 Compare June 6, 2016 11:08
petebacondarwin pushed a commit that referenced this pull request Jun 6, 2016
@Narretz @petebacondarwin
docs(ngComponentRouter): add deprecation notice and better install notes
c10dba1 
Yes, that contradicts itself.

Closes #14655
Closes #14717
@micaelmbagira
Copy link

Could you explain this one ? Is ngComponentRouter merged with ngRoute now ?

@Narretz
Copy link
Contributor Author

Narretz commented Jun 6, 2016

@micaelmbagira No that means the component router won't be developed any further, not in ng1 and not in ng2. The whole specification wasn't sufficient for the framework, and unfortunately we noticed this rather late. So ng2 is getting a new router, which will maybe ported to ng1.

@petebacondarwin
Copy link
Contributor

petebacondarwin commented Jun 6, 2016 •
edited
Loading

To be fair the "new" router that @Narretz talks about will still be called the Component Router. It is just that it will have some significant API changes and be a complete reimplementation so the current guide is not much use right now.

@nightcrawler91
Copy link

@Narretz May I suggest you add some of the context you just talked about to the docs as well? I was very surprised when I saw this being deprecated with no apparent explanation until I read this, and I think others would benefit from that as well.

@ulitiy
Copy link

ulitiy commented Jun 7, 2016

And the concept was much cleaner than router/ui-router so it's really disappointing to see it's being deprecated. Have started a couple of projects for my clients using this new promising technology that was deprecated in no time.

@petebacondarwin
Copy link
Contributor

The concept is not being deprecated :-) just this particular implementation.
There is a fancy new router in the works - but it is being developed for Angular 2 primarily and we need to look into how we can backport it to Angular 1.

@petebacondarwin
Copy link
Contributor

See http://angularjs.blogspot.co.uk/2016/06/improvements-coming-for-routing-in.html for info about the "new" version

@petebacondarwin
Copy link
Contributor

We need to look at how easy it will be to port this to Angular 1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes component: component router type: docs
Projects
None yet
Milestone
1.5.7
Development

Successfully merging this pull request may close these issues.
6 participants
@Narretz @micaelmbagira @petebacondarwin @nightcrawler91 @ulitiy @googlebot