This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat(ngMessagesInclude): don't break on empty (or whitespace-only) templates #14726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // we don't want to pollute the DOM anymore by keeping an empty directive element | ||
| element.remove(); | ||
| }); | ||
| if (isString(html) && !html.trim()) { |
There was a problem hiding this comment.
trim is doing an isString check, so we should be able to skip it here
There was a problem hiding this comment.
The isString is needed
There was a problem hiding this comment.
The isString() is needed in case the request returns some non-string data. This is normally not the case, but can happen (especially in tests).
I didn't test for it explicitly though...
There was a problem hiding this comment.
Yes that's why I was confused. If it's not tested it's not really specified. But in that case it's not big deal
|
LGTM |
1 similar comment
|
LGTM |
Narretz
pushed a commit
to Narretz/angular.js
that referenced
this pull request
Jun 8, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature (or bug fix - depends)
What is the current behavior? (You can also link to an open issue here)
Using
ngMessagesIncludewith an empty template, throws an error. This happens, because when trying to$compilethe template, jqLite thinks we are trying to call it with a selector.See #12941.
What is the new behavior (if this is a feature change)?
Using
ngMessagesIncludewith an empty template (or a template that contains only whitespace), will not throw.Does this PR introduce a breaking change?
Only if you relied on
ngMessagesIncludethrowing an error on empty templates.Please check if the PR fulfills these requirements
Docs have been added / updated (for bug fixes / features)Other information:
Fixes #12941.