Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

doc(disqus): Add integration to disqus discussion thread service #564

Closed
wants to merge 3 commits into from

Conversation

dandoyon
Copy link
Contributor

  • add loadDisqus method to be called inside afterPartialLoaded
  • add div container for disqus threads
  • add style for disqus threads in css
  • requires signing up for disqus account and creating a site with key of 'angularjs'

- add loadDisqus method to be called afterPartialLoaded

- add div container for disqus threads
…isqus-integration

Conflicts:
	docs/src/templates/docs.js
@IgorMinar
Copy link
Contributor

sorry about the delay. I'll get to this next week. we are too busy with getting forms ready.

@dandoyon
Copy link
Contributor Author

dandoyon commented Oct 7, 2011

NP, same here. Have a great weekend

-----Original Message-----
From: Igor Minar [mailto:[email protected]]
Sent: Friday, October 07, 2011 3:34 PM
To: dandoyon
Subject: Re: [angular.js] doc(disqus): Add integration to disqus discussion thread service (#564)

sorry about the delay. I'll get to this next week. we are too busy with getting forms ready.

Reply to this email directly or view it on GitHub:

#564 (comment)

No virus found in this message.
Checked by AVG - www.avg.com
Version: 10.0.1410 / Virus Database: 1520/3943 - Release Date: 10/07/11

@IgorMinar
Copy link
Contributor

moved the code to PR #627

@IgorMinar IgorMinar closed this Oct 31, 2011
@dandoyon
Copy link
Contributor Author

dandoyon commented Nov 1, 2011

Igor, thanks again for integration hopefully not so painful. I pulled down the 10.5 and was pleasantly
surprised to see it in there. I did notice on pages where the content is below the left hand nav, the
disqus stuff floats left. I originally had float: right because of this. It was off by a pixel or two (as far
as alignment with the div above. CSS is not my forte...

@IgorMinar
Copy link
Contributor

thanks for pointing that out. I fixed the issue: http://git.io/fZHHsg

/i

On Tue, Nov 1, 2011 at 1:34 PM, dandoyon <
[email protected]>wrote:

Igor, thanks again for integration hopefully not so painful. I pulled down
the 10.5 and was pleasantly
surprised to see it in there. I did notice on pages where the content is
below the left hand nav, the
disqus stuff floats left. I originally had float: right because of this.
It was off by a pixel or two (as far
as alignment with the div above. CSS is not my forte...

Reply to this email directly or view it on GitHub:
#564 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants