Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

feat(ngLog): provides support to debug the application in chosen level #8303

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 47 additions & 4 deletions src/ng/log.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
*/
function $LogProvider(){
var debug = true,
level = 'log',
self = this;

/**
Expand All @@ -63,6 +64,15 @@ function $LogProvider(){
}
};

this.debugLevel = function(flag) {
if (isDefined(flag)) {
level = flag;
return this;
} else {
return level;
}
};

this.$get = ['$window', function($window){
return {
/**
Expand All @@ -72,7 +82,15 @@ function $LogProvider(){
* @description
* Write a log message
*/
log: consoleLog('log'),
log: (function () {
var fn = consoleLog('log');

return function() {
if (level == 'log') {
fn.apply(self, arguments);
}
};
}()),

/**
* @ngdoc method
Expand All @@ -81,7 +99,15 @@ function $LogProvider(){
* @description
* Write an information message
*/
info: consoleLog('info'),
info: (function () {
var fn = consoleLog('info');

return function() {
if (level == 'log' || level == 'info') {
fn.apply(self, arguments);
}
};
}()),

/**
* @ngdoc method
Expand All @@ -90,7 +116,15 @@ function $LogProvider(){
* @description
* Write a warning message
*/
warn: consoleLog('warn'),
warn: (function () {
var fn = consoleLog('warn');

return function() {
if (level == 'log' || level == 'info' || level == 'warn') {
fn.apply(self, arguments);
}
};
}()),

/**
* @ngdoc method
Expand All @@ -99,7 +133,15 @@ function $LogProvider(){
* @description
* Write an error message
*/
error: consoleLog('error'),
error: (function () {
var fn = consoleLog('error');

return function() {
if (level == 'log' || level == 'info' || level == 'warn' || level == 'error') {
fn.apply(self, arguments);
}
};
}()),

/**
* @ngdoc method
Expand Down Expand Up @@ -133,6 +175,7 @@ function $LogProvider(){
}

function consoleLog(type) {

var console = $window.console || {},
logFn = console[type] || console.log || noop,
hasApply = false;
Expand Down
46 changes: 45 additions & 1 deletion test/ng/logSpec.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
/* global $LogProvider: false */
'use strict';

function initService(debugEnabled) {
function initService(debugEnabled, debugLevel) {
return module(function($logProvider){
$logProvider.debugEnabled(debugEnabled);
$logProvider.debugLevel(debugLevel);
});
}

Expand Down Expand Up @@ -178,4 +179,47 @@ describe('$log', function() {
expect(errorArgs).toEqual(['abc', 'message\nsourceURL:123']);
});
});

describe('$logLevel', function() {

it('should log all levels if not defined', function(){
$window.console = {log: log,
warn: warn,
info: info,
error: error,
debug: debug};
},

function($log) {
$log.log();
$log.info();
$log.warn();
$log.error();
$log.debug();
expect(logger).toEqual('log;info;warn;error;debug;');

});

it('should log only errors and warns if warn level is defined', function(){
$window.console = {log: log,
warn: warn,
info: info,
error: error,
debug: debug};
initService(true, 'warn');
},

function($log) {
$log.log();
$log.info();
$log.warn();
$log.error();
$log.debug();
expect(logger).toEqual('warn;error;debug;');

});

});


});