-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Added log enablers/disablers for all logger types on $logProvider #8832
base: master
Are you sure you want to change the base?
Added log enablers/disablers for all logger types on $logProvider #8832
Conversation
Can you squash your commits and follow the commit message guidelines? |
160715c
to
9ab91b0
Compare
Regarding squashing, I unfortunately merged in changes from master and cannot remember how to cherry pick and squash two commits together since they are no longer one right after the other. Can you advise? It has been a while (blush) |
The easiest way to squash is with an interactive rebase. |
ya I tried that, but I get a list of about 1000 commits :( I think it is because I merged. |
@btford can you handle this for me? lol. I may have SOL'd myself with this |
9ab91b0
to
1a7fc31
Compare
K, this should be ready. I went ahead and just redid the work to avoid combing through hundreds of commits for a squash. Should be good to go now. Thanks @btford |
|
||
return function() { | ||
if (log) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's no way to toggle this setting after the config phase (without hacks).
A smaller solution would be log: log ? consoleLog('log') : noop
However this still looks really big and maybe not that useful. Something closer to karma's logLevels might make more sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, interesting. This is literally the same code used for the existing debugEnabled function. Do we want to change how that works as well?
02dc2aa
to
fd2d6c0
Compare
cad9560
to
f294244
Compare
e8dc429
to
e83fab9
Compare
4dd5a20
to
998c61c
Compare
This is a pretty simple update. It extends the log provider to allow toggling for each log output type, instead of just for
$log.debug
.