This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($injector): throw when factory $get method does not return a value #9210
+64
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going through old issues assigned to me --- PTAL |
BREAKING CHANGE: Previously, not returning a value would fail silently, and an application trying to inject the value owuld inject an undefined value, quite possibly leading to a TypeError. Now, the application will fail entirely, and a reason will be given. Closes angular#4575
| } | ||
| }; | ||
| }); | ||
| ``` |
|
I like this change from a usability perspective, but I'm not sure if it's worth the few extra bytes. @IgorMinar what do you think? |
|
this looks good to me. |
jeffbcross
force-pushed
the
master
branch
2 times, most recently
from
abdaab7 to
30996f8
Compare
|
👏 |
bullgare
pushed a commit
to bullgare/angular.js
that referenced
this pull request
Oct 9, 2014
BREAKING CHANGE: Previously, not returning a value would fail silently, and an application trying to inject the value owuld inject an undefined value, quite possibly leading to a TypeError. Now, the application will fail entirely, and a reason will be given. Closes angular#4575 Closes angular#9210
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
Previously, not returning a value would fail silently, and an application
trying to inject the value owuld inject an undefined value, quite possibly
leading to a TypeError. Now, the application will fail entirely, and a reason
will be given.
Closes #4575