This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat(select): ngOptions support disabling options #9854
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend the ngOptions DSL to support disabling options. Since <option> elements are generated by ngOptions, we cannot use ngDisabled in this scenario. Via extend the DSL, user have control over if a option is diabled on arbitrary condition. This commit insert a `disable if cond` match syntax into NG_OPTIONS_REGEXP, change other match index accordingly, add disabled attribute to null option element and newly cloned option elements, add 2 new unit tests, and change docs as well. Closes angular#638
|
Hello angular team: |
|
@cades thnx for the patch. It looks good after very first quick look and it adds support for something that was long requested so we should spend more time reviewing it and eventually landing. Personally I would like to see more tests, for example - how disabled / enabled state changes in response to model changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the ngOptions DSL to support disabling options. Since
elements are generated by ngOptions, we cannot use ngDisabled in this
scenario. Via extend the DSL, user have control over if a option
is diabled on arbitrary condition.
This commit insert a
disable if condmatch syntax intoNG_OPTIONS_REGEXP, change other match index accordingly, add disabled
attribute to null option element and newly cloned option elements,
add 2 new unit tests, and change docs as well.
Closes #638