We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular: 15.2.1
Firebase: 9.17.2
AngularFire: 7.5.0
Other (e.g. Ionic/Cordova, Node, browser, operating system):
Steps to set up and reproduce
npm install @angular/fire
npm ls webpack --omit=dev
[email protected] C:\Users\name\Projects\my-project `-- (empty)
[email protected] C:\Users\name\Projects\my-project `-- @angular/[email protected] `-- [email protected] `-- [email protected] `-- [email protected] `-- [email protected] deduped
A search of this repository does not show that file-loader is used anywhere, maybe it can be removed from https://github.com/angular/angularfire/blob/master/src/package.json? But I could be wrong.
file-loader
Webpack should probably not be a (production)dependency, but a devDependency instead?
Running npm audit --omit=dev is how I noticed this dependency: GHSA-hc6q-2mpp-qw7j
npm audit --omit=dev
The text was updated successfully, but these errors were encountered:
This issue does not seem to follow the issue template. Make sure you provide all the required information.
Sorry, something went wrong.
Ah we used to use file-loader but no longer do, since Firestore fixed their bundling issue. We'll remove this, thanks for pointing out.
Quick fixes (#3362)
b4c3da8
* Fix semver check for ng-deploy * Drop file-loader, fixes #3324
Successfully merging a pull request may close this issue.
Version info
Angular: 15.2.1
Firebase: 9.17.2
AngularFire: 7.5.0
Other (e.g. Ionic/Cordova, Node, browser, operating system):
How to reproduce these conditions
Steps to set up and reproduce
npm install @angular/fire
npm ls webpack --omit=dev
Expected behavior
Actual behavior
Additional information
A search of this repository does not show that
file-loader
is used anywhere, maybe it can be removed from https://github.com/angular/angularfire/blob/master/src/package.json? But I could be wrong.Webpack should probably not be a (production)dependency, but a devDependency instead?
Running
npm audit --omit=dev
is how I noticed this dependency: GHSA-hc6q-2mpp-qw7jThe text was updated successfully, but these errors were encountered: