Skip to content

@angular/fire indirectly depends on webpack #3324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ionaru opened this issue Mar 15, 2023 · 2 comments · Fixed by #3362
Closed

@angular/fire indirectly depends on webpack #3324

Ionaru opened this issue Mar 15, 2023 · 2 comments · Fixed by #3362

Comments

@Ionaru
Copy link

Ionaru commented Mar 15, 2023

Version info

Angular: 15.2.1

Firebase: 9.17.2

AngularFire: 7.5.0

Other (e.g. Ionic/Cordova, Node, browser, operating system):

  • @ionic/angular: 6.6.0
  • Node: 18.13.0
  • Windows 11

How to reproduce these conditions

Steps to set up and reproduce

  • npm install @angular/fire
  • npm ls webpack --omit=dev

Expected behavior

[email protected] C:\Users\name\Projects\my-project
`-- (empty)

Actual behavior

[email protected] C:\Users\name\Projects\my-project
`-- @angular/[email protected]
  `-- [email protected]
    `-- [email protected]
      `-- [email protected]
        `-- [email protected] deduped

Additional information

A search of this repository does not show that file-loader is used anywhere, maybe it can be removed from https://github.com/angular/angularfire/blob/master/src/package.json? But I could be wrong.

Webpack should probably not be a (production)dependency, but a devDependency instead?

Running npm audit --omit=dev is how I noticed this dependency: GHSA-hc6q-2mpp-qw7j

@google-oss-bot
Copy link

This issue does not seem to follow the issue template. Make sure you provide all the required information.

@jamesdaniels
Copy link
Member

Ah we used to use file-loader but no longer do, since Firestore fixed their bundling issue. We'll remove this, thanks for pointing out.

jamesdaniels added a commit that referenced this issue May 27, 2023
* Fix semver check for ng-deploy
* Drop file-loader, fixes #3324
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants