Skip to content

add: export interface Item #1839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2018
Merged

add: export interface Item #1839

merged 1 commit into from
Aug 27, 2018

Conversation

marius-turtle
Copy link

Description: Updating the documentation
for usage at the element-declarations in the class, otherwise error

Checklist

  • Issue number for this PR: #nnn (required) -
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

Code sample

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
for usage at the element-declarations in the class, otherwise error
@EdricChan03
Copy link
Contributor

Could you modify your commit to use a valid commit type?

Something like:

docs(firestore/documents): add missing interface

See the Angular Commit Guidelines for more info.

@jamesdaniels jamesdaniels merged commit 6148a86 into angular:master Aug 27, 2018
@jamesdaniels
Copy link
Member

Thanks for the fix. I altered the commit message with a squash.

@marius-turtle marius-turtle deleted the patch-1 branch August 28, 2018 04:24
@marius-turtle
Copy link
Author

Thank you. I am quite new at committing something on GitHub, next time I will use the template-format from the Angular Commit Guidelines.

sulco pushed a commit to sulco/angularfire2 that referenced this pull request Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants