-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix: fix memory leak on SSR #2243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
441f9b0
chore: allow passsing Scheduler to fromRef
5a9550c
fix: fix memory leak in SSR
47f1490
fix(universal-test): bring back universal-test app
ae2d800
fix: use macrotask
cffb209
fix: schedule completed and error notifications in the specified sche…
90e3f9f
chore: update misleading comment
ValentinFunk a63b20c
fix(typings): don't type ZoneScheduler.delegate to support old TS ver…
9c9658c
fix(keepUnstableUntilFirst): multicast only after rescheduling
ec16f2c
fix(keepUnstableUntilFirst): schedule emissions inside of angular syn…
38e6f51
Merge branch 'master' into master
jamesdaniels File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI I've been starting to leave comments for anything I can drop in the next major, mostly older typescript work arounds.
// SEMVER drop any when we upgrade typescript in the next major
or something along those lines.I'm aiming to break off from older versions of typescript, ng, and firebase alongside ng 9.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also feel free to suggest any API breaks that would make maintainability easier too, as you saw I already had two different styles of zone patching I was supporting.