Skip to content

fix: fix memory leak on SSR #2243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 21, 2020
2 changes: 1 addition & 1 deletion src/core/angularfire2.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ function noop() { }
* Schedules tasks so that they are invoked inside the Zone that is passed in the constructor.
*/
export class ZoneScheduler implements SchedulerLike {
constructor(private zone: any, private delegate = asyncScheduler) { }
constructor(private zone: any, private delegate: any = asyncScheduler) { }
Copy link
Member

@jamesdaniels jamesdaniels Dec 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I've been starting to leave comments for anything I can drop in the next major, mostly older typescript work arounds. // SEMVER drop any when we upgrade typescript in the next major or something along those lines.

I'm aiming to break off from older versions of typescript, ng, and firebase alongside ng 9.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also feel free to suggest any API breaks that would make maintainability easier too, as you saw I already had two different styles of zone patching I was supporting.


now() {
return this.delegate.now();
Expand Down