Skip to content

Removing the problematic share from the zone.js changes #2315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 6, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 2 additions & 27 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,37 +6,12 @@ node_js:
addons:
chrome: stable

cache:
yarn: true
directories:
- node_modules
- "$HOME/.npm"
- "$HOME/.cache"

env:
- CANARY=false
- CANARY=true

matrix:
fast_finish: true
allow_failures:
- env: CANARY=true

branches:
only:
- master # otherwise pull requests get built twice
- v5

install:
- |
if $CANARY; then
yarn upgrade && yarn add firebase@canary
else
if [ "$TRAVIS_BRANCH" = "master" -a "$TRAVIS_PULL_REQUEST" = "false" ]; then
yarn upgrade
else
yarn install --frozen-lockfile
fi
fi
install: yarn install --frozen-lockfile

script:
- yarn build
Expand Down
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
<a name="5.4.2"></a>
## [5.4.2](https://github.com/angular/angularfire2/compare/5.4.1...5.4.2) (2020-02-06)


### Bug Fixes

* **core:** fixing a problem with hot/cold observables resulting in missed events ([#2315](https://github.com/angular/angularfire2/issues/2315)) ([6dd0409](https://github.com/angular/angularfire2/commit/6dd0409))


<a name="5.4.1"></a>
## [5.4.1](https://github.com/angular/angularfire2/compare/5.4.0...5.4.1) (2020-02-05)

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@angular/fire",
"version": "5.4.1",
"version": "5.4.2",
"description": "The official library of Firebase and Angular.",
"private": true,
"scripts": {
Expand Down
5 changes: 3 additions & 2 deletions src/core/angularfire2.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,9 @@ export function ɵkeepUnstableUntilFirstFactory(
// Run the subscribe body outside of Angular (e.g. calling Firebase SDK to add a listener to a change event)
subscribeOn(schedulers.outsideAngular),
// Run operators inside the angular zone (e.g. side effects via tap())
observeOn(schedulers.insideAngular),
share()
observeOn(schedulers.insideAngular)
// This isn't working correctly #2309, #2314, #2312
// share()
);
}
}
Expand Down