Skip to content

Duplicated CSS imports #12069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alanxone opened this issue Jul 5, 2018 · 2 comments · Fixed by #12077
Closed

Duplicated CSS imports #12069

alanxone opened this issue Jul 5, 2018 · 2 comments · Fixed by #12077
Assignees
@crisbeto
Labels
P4 A relatively minor issue that is not relevant to core functions

Comments

@alanxone
Copy link

alanxone commented Jul 5, 2018 •
edited
Loading

https://github.com/angular/material2/blob/89cad3fd1511def6ea9aa17c867f9872bf774f2c/src/lib/menu/menu.scss#L3

https://github.com/angular/material2/blob/89cad3fd1511def6ea9aa17c867f9872bf774f2c/src/lib/menu/menu.scss#L5

Why importing the same file twice?
@FrederikSchlemmer
Copy link
Contributor

Seems like one import isn't needed.

@AndrewTW Would you like to make a PR? Otherwise I would do this.

@crisbeto crisbeto self-assigned this Jul 5, 2018
@crisbeto crisbeto added has pr P4 A relatively minor issue that is not relevant to core functions labels Jul 5, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 5, 2018
@crisbeto
build: don't allow duplicate scss imports
8a1a314 
Enables a rule that doesn't allow duplicate `@import` statements. Also fixes a failure.

Fixes angular#12069.
@crisbeto crisbeto mentioned this issue Jul 5, 2018
Merged
mmalerba pushed a commit that referenced this issue Jul 5, 2018
@crisbeto @mmalerba
build: don't allow duplicate scss imports (#12077)
5c41410 
Enables a rule that doesn't allow duplicate `@import` statements. Also fixes a failure.

Fixes #12069.
mmalerba pushed a commit that referenced this issue Jul 9, 2018
@crisbeto @mmalerba
build: don't allow duplicate scss imports (#12077)
d398384 
Enables a rule that doesn't allow duplicate `@import` statements. Also fixes a failure.

Fixes #12069.
victoriaaa234 pushed a commit that referenced this issue Jul 25, 2018
@crisbeto @victoriaaa234
build: don't allow duplicate scss imports (#12077)
8c980f1 
Enables a rule that doesn't allow duplicate `@import` statements. Also fixes a failure.

Fixes #12069.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: don't allow duplicate scss imports crisbeto/material2
3 participants
@crisbeto @alanxone @FrederikSchlemmer