Skip to content

Disabling radio button dynamically does not change button style #12125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mgurnani opened this issue Jul 10, 2018 · 1 comment · Fixed by #12127
Closed

Disabling radio button dynamically does not change button style #12125

mgurnani opened this issue Jul 10, 2018 · 1 comment · Fixed by #12127
Assignees
@crisbeto
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@mgurnani
Copy link

mgurnani commented Jul 10, 2018 •
edited
Loading

Bug, feature request, or proposal:

Bug

What is the expected behavior?

Disabling a radio button dynamically should change button style to greyed out

What is the current behavior?

Disabling a radio button dynamically keeps the accent color

What are the steps to reproduce?

StackBlitz: https://angular-4uzxq2.stackblitz.io

What is the use-case or motivation for changing an existing behavior?

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Current

Is there anything else we should know?
@crisbeto crisbeto self-assigned this Jul 10, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 10, 2018
@crisbeto
fix(radio): circle not being greyed out when disabled
de0700f 
Fixes the radio button circle not being greyed out when it is disabled. It seems like we had the styles in place already, however they were with a lower specificity than the other theme styles.

Fixes angular#12125.
@crisbeto crisbeto mentioned this issue Jul 10, 2018
Merged
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent has pr labels Jul 10, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 10, 2018
@crisbeto
fix(radio): circle not being greyed out when disabled
3b1280a 
Fixes the radio button circle not being greyed out when it is disabled. It seems like we had the styles in place already, however they were with a lower specificity than the other theme styles.

Fixes angular#12125.
jelbourn pushed a commit that referenced this issue Jul 11, 2018
@crisbeto @jelbourn
fix(radio): circle not being greyed out when disabled
d8d3a70 
Fixes the radio button circle not being greyed out when it is disabled. It seems like we had the styles in place already, however they were with a lower specificity than the other theme styles.

Fixes #12125.
jelbourn pushed a commit that referenced this issue Jul 12, 2018
@crisbeto @jelbourn
fix(radio): circle not being greyed out when disabled (#12127)
85b8f32 
Fixes the radio button circle not being greyed out when it is disabled. It seems like we had the styles in place already, however they were with a lower specificity than the other theme styles.

Fixes #12125.
victoriaaa234 pushed a commit that referenced this issue Jul 25, 2018
@crisbeto @victoriaaa234
fix(radio): circle not being greyed out when disabled (#12127)
acedadc 
Fixes the radio button circle not being greyed out when it is disabled. It seems like we had the styles in place already, however they were with a lower specificity than the other theme styles.

Fixes #12125.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(radio): circle not being greyed out when disabled crisbeto/material2
2 participants
@crisbeto @mgurnani