-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Menus/Selects/ExpansionPanel should follow Material guidelines #3814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Aligns the menu panel appearance with [the spec](https://material.io/guidelines/components/menus.html) by: * Reducing the elevation from 8 to 3. * Adding a slight border radius. * Tweaking the animation to match the examples. Relates to angular#3814.
Aligns the menu panel appearance with [the spec](https://material.io/guidelines/components/menus.html) by: * Reducing the elevation from 8 to 3. * Adding a slight border radius. * Tweaking the animation to match the examples. Relates to angular#3814.
Aligns the menu panel appearance with [the spec](https://material.io/guidelines/components/menus.html) by: * Reducing the elevation from 8 to 3. * Adding a slight border radius. * Tweaking the animation to match the examples. Relates to angular#3814.
Aligns the menu panel appearance with [the spec](https://material.io/guidelines/components/menus.html) by: * Reducing the elevation from 8 to 3. * Adding a slight border radius. * Tweaking the animation to match the examples. Relates to #3814.
Aligns the menu panel appearance with [the spec](https://material.io/guidelines/components/menus.html) by: * Reducing the elevation from 8 to 3. * Adding a slight border radius. * Tweaking the animation to match the examples. Relates to #3814.
Aligns the menu panel appearance with [the spec](https://material.io/guidelines/components/menus.html) by: * Reducing the elevation from 8 to 3. * Adding a slight border radius. * Tweaking the animation to match the examples. Relates to #3814.
@crisbeto Is it also possible to apply the same fixes to the Expansion Panel, missing border radius, wrong shadows, and separator hardly visible : |
@crisbeto Update the issue so that it concerns the 3 components. |
I am also looking to style the Expansion Panel's description (while collapsed) in line with how the spec presents it. I don't think the spec ever actually states that the description portion of multiple panels in the same "group" (grouping of multiple panels is also never specifically mentioned in the spec...) must align in a column with each other, but each example image does exhibit this behavior. The current implementation just allows each panel's title and description fields to resize according to their content, which means that the descriptions will never line up with each other. This can be seen in the docs examples and gets really pronounced with many panels of varying title width. I have used a variant of the fix described in #5173 ( |
Bug:
What is the expected behavior?
The components should follow the Material guidelines
What is the current behavior?
For Menu/Select/ExpansionPanel:
For Menu/Select:
Current Menu animation:

Menu Animation according to the Material Guidelines:

Current Select animation:

Select Animation according to the Material Guidelines:

Which versions of Angular, Material, OS, browsers are affected?
Material 5.0.0-rc0
The text was updated successfully, but these errors were encountered: